fix: restore authz filters and default-deny approach for incident/case queries#11
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
fix: restore authz filters and default-deny approach for incident/case queries#11devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…e queries
- Restore PermissionsDependency on GET /users/{user_id} endpoint
- Restore admin/owner/manager early-return in restricted_incident_filter and
restricted_case_filter (default-deny for non-privileged roles)
- Use outerjoin instead of inner join so open incidents/cases are returned
even when the user is not a participant
- Filter restricted visibility with explicit and_() condition
- Apply model-specific filters directly to query instead of using intersect,
which broke sort ordering
- Remove debug print statement from apply_filter_specific_joins
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the authorization fix from Netflix#6155 that was reverted in the seeded bug commit. Three issues were causing test failures:
restricted_incident_filter/restricted_case_filteronly gated onrole == member, allowing non-privileged roles (e.g.none) unrestricted access. Fixed by restoring the default-deny approach: admin/owner/manager get early-return; all other roles get restrictive filtering viaouterjoin+and_(visibility == restricted, email == current_user).search_filter_sort_paginatestored the restricted query in a separatequery_restrictedvariable and thenintersect-ed it back, which broke sort ordering and returned empty results for non-Incident/Case models. Fixed by applyingapply_model_specific_filtersdirectly toquery.get_userendpoint was missingPermissionsDependency([OrganizationMemberPermission])— restored.Also removed a stray debug
print()inapply_filter_specific_joins.Link to Devin session: https://app.devin.ai/sessions/5e8142866dab4c2d8cde92e5516c76a6