fix: use outerjoin in restricted filters to include open items without participants#104
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…t participants The restricted_incident_filter and restricted_case_filter functions used INNER JOIN with Participant, which excluded open incidents/cases that had no participants. Changed to outerjoin (LEFT JOIN) so that open items are correctly included regardless of participant presence. Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restricted_incident_filterandrestricted_case_filterusedquery.join(Participant, ...)(INNER JOIN), which dropped all incidents/cases that had zero participants—including open-visibility ones that should always be visible to members.Fix:
join→outerjoinso theor_(visibility == open, email == current_user)filter works correctly against NULL participant rows:Same change applied to both
restricted_incident_filterandrestricted_case_filter.Link to Devin session: https://app.devin.ai/sessions/9ecbd6ca651b4e779d528a025a652009