Fix behaviour of now() - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch started as addressing a problem with statement binding; a regression had arisen when statements were chained in a sequence but the result of the first was bound to a variable. Fixed.
In the course of that work added a test, and that uncovered an inconsistency with evaluating the
now()function. We have added Nature::Instant to mark a system-provided effectful function which does not take an editable command like Nature::Command does. This then clarified thatnow()'s value (a timestamp) is indeed printed to the terminal because it is a Return. If the value is subsequently captured in a binding and/or made the result of a step as Done that is separate and not printed as such.Bump and refine dependencies.
Add some preliminary test coverage for the language server code path.