build: pin tl-parser to C11 for GCC 15 / Clang 16 compatibility#3679
Open
FalconEagleTest wants to merge 1 commit into
Open
build: pin tl-parser to C11 for GCC 15 / Clang 16 compatibility#3679FalconEagleTest wants to merge 1 commit into
FalconEagleTest wants to merge 1 commit into
Conversation
The vendored wgetopt.c (Windows-only) uses K&R-style definitions and
the legacy declaration `extern char *getenv();`. GCC 15 and Clang 16
default to -std=gnu23, where () means "no arguments", so the call
`getenv("POSIXLY_CORRECT")` is rejected as too many arguments.
Pin the tl-parser target to C11 on GCC/Clang. MSVC unaffected (the
existing /utf-8 /wd4101 /wd4244 /wd4267 block already handles it).
Host-side codegen helper -- no runtime impact.
Contributor
|
I would fix the prototype of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored wgetopt.c (Windows-only) uses K&R-style definitions and the legacy declaration
extern char *getenv();. GCC 15 and Clang 16 default to -std=gnu23, where () means "no arguments", so the callgetenv("POSIXLY_CORRECT")is rejected as too many arguments.Pin the tl-parser target to C11 on GCC/Clang. MSVC unaffected (the existing /utf-8 /wd4101 /wd4244 /wd4267 block already handles it). Host-side codegen helper -- no runtime impact.
Test plan
at
wgetopt.cwithout this patch).CMAKE_C_COMPILER_ID MATCHES "GNU|Clang").