Repository navigation
fix: publish the outprint image and let release-please pick the next version - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ghcr.io/taskmedia/outprint(run 41344384894,publish outprintfailed:…@sha256:08660dbc…: not found). Thedigests-outprint-*artifact pattern also matchesdigests-outprint-injector-*, so the job merged injector digests into theoutprintrepository.outprint-injectorwas unaffected. This also failsct installin feat(outprint): add Helm chart helm#26.release-as: "0.1.0"is still pinned, so release-please keeps proposing 0.1.0 (chore(main): release 1.0.0 #82) even though v0.1.0 exists.Change
digests-<image>-linux-*so the two images' artifacts no longer overlap.release-as. Withbump-minor-pre-major, thefeat:commits since v0.1.0 give 0.2.0.After merging
release-please should re-open #82 as 0.2.0 (close/recreate it if it stays at 0.1.0). Merging that release publishes
outprint:0.2.0;0.1.0stays untagged foroutprint. taskmedia/helm#26 then needsappVersion: "0.2.0".