Repository navigation
fix(outprint): run only one package sync at a time - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the first install of
homelabthe start Job and the CronJob began in the same second and ran on the same PVC. One pod failed (exit 2) and the retry succeeded, but two syncs can delete each other's working folders, and a pod could activate the revision that another pod had prepared but not yet validated./packages/.lock(a directory,mkdiris atomic) is taken by the sync step. A second sync logsanother sync holds the lockand does nothing. A lock older than 180 s is taken over (left behind by a pod that died or whose revision failed validation).emptyDirof that pod (/state/pending) instead of the PVC. validate and activate act only on what their own pod prepared, so a pod that skipped never activates someone else's revision.Test plan
ct lintpassescurrentand releases the lock