Repository navigation
ci: install only changed charts and skip kind when nothing installable - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ct install --allignores change detection, so every PR installs every chart on a kind cluster. In run 42304256932 (PR #32, which only touchespaperlessngx-ftp-bridge), lint correctly processed one chart while install ranipsec-vpn-server,outprint,paperless-gpt,paperlessngx-backupandvpn-ios-profile. The one changed chart is excluded from install, so it was never installed.Change
ct install --all->ct install --target-branch main, so only changed charts are installed (the exclusion is kept).installableoutput in thelist-changedstep: true when a changed chart other thanpaperlessngx-ftp-bridgeexists. Repo add, kind setup and install are gated on it; lint stays gated onchanged.Verification
ct list-changed --target-branch main --chart-dirs chartsoutputscharts/<name>lines (checked locally with simulated changes), which is what the filter matches against.paperlessngx-ftp-bridgeruns lint and skips kind/install; a PR touching e.g.outprintinstalls onlyoutprint.