Repository navigation
chore: share one pre-commit body with cloud and marketing - #603
Conversation
The hook ran the guard as a bare `sh` line, which stopped a refused commit only because Husky 9 runs hooks with `sh -e`. As a raw git hook the same lines carried on into lint-staged, whose passing exit let the refused commit through. `|| exit 1` stops it without depending on the runner, and a missing-file check says what to run instead of a bare `sh` error. This is the body taskless/taskless#426 and taskless/marketing#88 use, so all three repos run the same hook; the skill documents it.
|
@claude /review |
|
Claude finished @theCodeDrift's task in 1m 18s —— View job Review mode: incremental — read 0 prior review thread(s) before reviewing.
SummaryThe change is a correct, well-reasoned fix. I traced through both files plus the unchanged
Findings
No correctness, security, or test-adequacy issues found. This is a tooling/docs-only change (no runtime code, no changeset needed, as the PR description notes). |
No correctness findings; the one prose nit is answered inline and declined. Merging. — AI Coding Agent |
Repos that install the worktrees-pnpm skill through dotagents skip that install under CI, so on a runner the guard file may not exist, and the missing-file check from #603 would block every automated commit before the guard's own GITHUB_ACTIONS skip could run. taskless/marketing#88's review caught it; taskless/taskless#426 carries the same fix. taskless/cli tracks the guard in git, so it is always present here, but the body is adopted anyway so all three repos run one byte-identical hook, and the skill documents why the check sits inside the test.
Makes
.husky/pre-committhe same body taskless/taskless#426 and taskless/marketing#88 use, and documents it in theworktrees-pnpmskill so all three repos run one hook.sh "$guard" || exit 1. The old one-linesh <guard>stopped a refused commit only because Husky 9 runs hooks assh -e. As a raw git hook, the same lines carry on intolint-staged, and its passing exit lets the commit through.pnpm install(orpnpm dotagents install) instead of failing with a baresherror.pnpm exec lint-stagedin place ofnpx lint-staged.Measured in a scratch repo, with
lint-stagedstubbed to pass:This commit was made through the new hook from a worktree, so
pnpm exec lint-stagedresolves here.No changeset: repo tooling, nothing ships.