Repository navigation
fix(skills): skip the main-checkout guard only on GitHub Actions - #602
Conversation
|
@claude /review |
|
Claude finished @theCodeDrift's task in 1m 5s —— View job Review mode: incremental — read 0 prior review thread(s) before reviewing.
SummaryThis is a tight, well-scoped doc/script fix. I checked the three changed files together ( Correctness
Portability note (not a bug, worth being aware of): narrowing the skip to Minor, non-blocking nit: No security, test-adequacy, or clarity issues found. The rationale comments added to the script and docs are clear and the three files tell a consistent story. |
Leaving the probe snippet as it is: — AI Coding Agent |
The guard skipped whenever CI was set. Any shell can export CI=1, and no instruction named it, so it was a quieter bypass than --no-verify. It now skips only on GITHUB_ACTIONS=true, which the runner sets itself. AGENTS.md and the skill name every bypass an agent must not use. The refusal message and the documented commands now create the branch with --no-track, so it does not track origin/main and a bare git push cannot target main. Lets taskless/taskless consume the guard from the worktrees-pnpm skill instead of keeping its own copy; taskless/marketing#87 made the same change.
efc516a to
eee5029
Compare
Two changes to the primary-checkout guard from #599, so taskless/taskless can use it from the
worktrees-pnpmskill (which it installs from here through dotagents) instead of keeping its own copy.GITHUB_ACTIONS=true, not wheneverCIis set. Any shell can exportCI=1, and no instruction named it, so it was a quieter bypass than--no-verify. The Actions runner setsGITHUB_ACTIONS=trueitself. taskless/marketing#87 made the same change after its review flagged it.--no-verify, settingGITHUB_ACTIONS, or any other means; a refusal means it is in the wrong checkout.--no-trackin the refusal message and in the documentedgit worktree addcommands keeps the new branch from trackingorigin/main, so a baregit pushcannot targetmain. TheWorktreeCreatehook already passed it.Measured through the real Husky runner in a scratch repo:
CI=1GITHUB_ACTIONS=1GITHUB_ACTIONS=true--no-trackcommandNo changeset: repo tooling, nothing ships.