Skip to content

docs(agents): record the review rule and correct the worktree install rule - #601

Merged
theCodeDrift merged 1 commit into
mainfrom
docs/worktree-guidance-parity
Nov 2, 2026
Merged

theCodeDrift merged 1 commit into
mainfrom
docs/worktree-guidance-parity

Conversation

@theCodeDrift

Copy link
Copy Markdown
Member

Brings taskless/cli's worktree guidance in line with taskless/taskless and the marketing site, keeping the one intended difference.

  • New Requesting the Claude review section. On taskless/cli an agent always posts a standalone @claude /review: when opening a PR, and on a later push that adds significant new code. Never for review fixes, renames, doc tweaks or rebases, never twice for the same code. The other repos review automatically when a PR opens. This rule previously lived only in a user-level hook and a private memory.
  • The worktree base check confirms git rev-parse --is-shallow-repository is false before trusting rev-list --count HEAD..origin/main.
  • The install rule was wrong about the symptom. It said git commit fails in lint-staged. In fact .husky/_ is generated by the install and not tracked, and core.hooksPath points there, so an uninstalled worktree runs no hooks at all: lint-staged and the primary-checkout guard from chore: refuse commits in the primary checkout #599 are both skipped silently.

The cd … && pwd -P port for git before 2.31 is #600, separate so it can land on its own.

No changeset: repo docs, nothing ships.

@theCodeDrift

Copy link
Copy Markdown
Member Author

@claude /review

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @theCodeDrift's task in 1m 13s —— View job


Review complete

  • Read .prior-review.json (no prior threads/reviews found — this is the first review)
  • Fetch PR diff and metadata
  • Read changed file(s) in full context
  • Post review findings

Review mode: incremental — read 0 prior review thread(s) before reviewing. .prior-review.json contains no reviewThreads or reviews, only the triggering @claude /review comment itself — so there is nothing previously raised to classify as addressed or still-open. This is the first review of this PR.

Assessment

Docs-only change to AGENTS.md, verified against the current repo state rather than just read in isolation:

  • New "Requesting the Claude review" section — checked against .github/workflows/claude-code-review-on-demand.yml, which confirms this repo really does have only an on-demand @claude /review trigger (no pull_request: opened auto-review), matching the claimed asymmetry with the other Taskless repos. Accurate.
  • Shallow-clone check added to the worktree base-check bullet (AGENTS.md:117) — correctly points back to the existing shallow-clone guidance at AGENTS.md:36-51, and the ordering (check shallow-ness before trusting rev-list --count) is the right fix: rev-list --count HEAD..origin/main on a shallow clone can't be trusted the way the surrounding prose assumes.
  • Install-rule correction (AGENTS.md:118) — verified directly: package.json wires "prepare": "husky", and the tracked .husky/pre-commit here is a plain Husky v9 script with no .husky/_/husky.sh sourcing, so core.hooksPath pointing at the install-generated, untracked .husky/_ is exactly why an uninstalled worktree's git commit runs no hooks at all (silently) rather than failing loudly in lint-staged as the old text claimed. The new wording is the more accurate description of the actual failure mode.

No correctness, security, or clarity issues found in the changed lines. Nothing NEW to flag and nothing from a prior review to repeat, since there was no prior review.

… rule

Aligns worktree guidance with the other Taskless repos:

- The always-request `@claude /review` rule for taskless/cli now lives
  in AGENTS.md, where every harness and teammate reads it.
- The worktree base check confirms the clone is not shallow before
  trusting rev-list.
- An uninstalled worktree does not fail at commit: .husky/_ is
  generated, not tracked, so git runs no hooks at all and lint-staged
  and the primary-checkout guard are skipped silently.
@theCodeDrift
theCodeDrift force-pushed the docs/worktree-guidance-parity branch from 29c93d2 to c2eb3eb Compare November 2, 2026 02:23
@theCodeDrift

Copy link
Copy Markdown
Member Author

Re: @github-actions — "Claude finished @theCodeDrift's task in 1m 13s … Review complete"
#601 (comment)

No findings, nothing changed.

— AI Coding Agent

@theCodeDrift
theCodeDrift merged commit a9b714f into main Nov 2, 2026
4 checks passed
@theCodeDrift
theCodeDrift deleted the docs/worktree-guidance-parity branch November 2, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant