Repository navigation
chore: refuse commits in the primary checkout #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+64
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
.agents/skills/worktrees-pnpm/scripts/refuse-main-checkout.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #!/usr/bin/env sh | ||
| # | ||
| # pre-commit guard: refuse commits made in the repository's primary checkout. | ||
| # | ||
| # All work happens in a worktree under .agents/.worktrees/. The primary checkout | ||
| # is the one every agent is told never to touch, because an agent that lands | ||
| # there edits, branches and commits in the user's own working tree. Telling it | ||
| # not to has not been enough, so the commit is refused instead. | ||
| # | ||
| # The test: in a linked worktree, --git-dir is .git/worktrees/<name> while | ||
| # --git-common-dir is the shared .git. In the primary checkout both are the same | ||
| # directory. This does not care what branch is checked out, so it also stops a | ||
| # commit to a feature branch that someone checked out in the primary tree. | ||
| # | ||
| # Not enforced in CI: the runners commit from a plain clone (changeset version | ||
| # PRs, review actions), and a plain clone is a primary checkout. | ||
| # | ||
| # Escape hatch for a deliberate commit here: git commit --no-verify | ||
| set -eu | ||
|
|
||
| if [ -n "${CI:-}" ]; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| dirs=$(git rev-parse --path-format=absolute --git-dir --git-common-dir) | ||
| git_dir=$(printf '%s\n' "$dirs" | sed -n 1p) | ||
| common_dir=$(printf '%s\n' "$dirs" | sed -n 2p) | ||
|
|
||
| if [ "$git_dir" = "$common_dir" ]; then | ||
| top=$(git rev-parse --show-toplevel) | ||
| cat >&2 <<EOF | ||
| Refusing to commit in the primary checkout ($top). | ||
|
|
||
| Work in a worktree instead: | ||
| git fetch origin +refs/heads/main:refs/remotes/origin/main | ||
| git worktree add -b <branch> .agents/.worktrees/<name> origin/main | ||
| cd .agents/.worktrees/<name> && pnpm install | ||
|
|
||
| To commit here deliberately: git commit --no-verify | ||
| EOF | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| sh .agents/skills/worktrees-pnpm/scripts/refuse-main-checkout.sh | ||
|
theCodeDrift marked this conversation as resolved.
Resolved
|
||
| npx lint-staged | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.