Repository navigation
fix(reference): match eval with any number of arguments in no-eval-call - #595
Merged
Merged
Conversation
The prompt asks for any call to eval(), but the pattern eval($ARG) matched exactly one argument, so downstream evals graded generated fail cases for eval() and eval(a, b) as wrong. Match any arity, add a fail case for zero and two arguments, name the arities in the prompt, and verify the published sg reference against its own cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sg half of #591. #592 widened the vale reference;
no-eval-callstill usedpattern: eval($ARG), which matches exactly one argument, though its prompt asks for any call toeval(). A generator that followscreate-sg-rulewrites fail cases on each side of the arity boundary (eval(),eval(a, b)), and step 5 of the eval protocol (our rule against their fixtures) failed on them: 2 of 3eval:sgruns onclaude-sonnet-5.eval($$$ARGS).eval-no-argsandeval-multiple-args;reference.jsonregenerated.reference-verify.test.tsnow verifies the published sg entry against its own cases, as it already did for vale. With the old pattern restored it fails with the same twofail case did not firelines from the issue.versionis unchanged since only one entry's content moved.Fixes #591