Skip to content

Create function to operate this from outside (with import)#6

Open
jeanmi151 wants to merge 4 commits into
tarwirdur:masterfrom
jeanmi151:master
Open

Create function to operate this from outside (with import)#6
jeanmi151 wants to merge 4 commits into
tarwirdur:masterfrom
jeanmi151:master

Conversation

@jeanmi151
Copy link
Copy Markdown

This is to support outside sourcing the file.

Like that we can do

from mbtiles2osmand import mbtiles2osmand_convertion

mbtiles2osmand_convertion("input.mbtiles", "output.sqlite", force_overwrite=True)

from another python script

@tarwirdur
Copy link
Copy Markdown
Owner

  1. There are only changes in the PR regarding the file mbtiles2osmand.py . There are also unite_osmand.py .
  2. To call from third-party applications, it is probably better to use the sqlite connection rather than the file name as an argument.
  3. I think we need to change the structure of the project so that it can be placed as a package on pypi.org .

I'm not ready to accept PR in its current form yet.

@jeanmi151
Copy link
Copy Markdown
Author

Hey @tarwirdur ,
Thanks for your answer, I take into account your comments and modify my PR for 1. and 2.

For 3. I might let you do it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants