Repository navigation
Record accumulated architecture and agent-writing guidance - #936
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| readonly phases: Stream<ComponentExpansionPhase, void>; | ||
| } | ||
|
|
||
| // Existing Core type; its meaning is unchanged. |
There was a problem hiding this comment.
Redundant comment — restates what the code does.
Suggested change
| // Existing Core type; its meaning is unchanged. |
| interface ReplTree<Action> { | ||
| validate(descriptions: readonly ReplDescription<Action>[]): Result<void>; | ||
| apply(descriptions: readonly ReplDescription<Action>[]): Operation<Result<void>>; | ||
| // Other existing members remain unchanged. |
There was a problem hiding this comment.
Redundant comment — restates what the code does.
Suggested change
| // Other existing members remain unchanged. |
| interface ComponentDeclaration { | ||
| /** Forms this declaration makes available to generated XMD. */ | ||
| readonly generated?: Readonly<Partial<Record<InvocationForm, GeneratedForm>>>; | ||
| // Existing declaration members remain. |
There was a problem hiding this comment.
Redundant comment — restates what the code does.
Suggested change
| // Existing declaration members remain. |
| interface ExecutionApi { | ||
| /** Checks the retained journal must pass before this execution replays it. */ | ||
| readonly admissions: readonly JournalAdmission[]; | ||
| // Existing members, including the accepted init member, remain. |
There was a problem hiding this comment.
Redundant comment — restates what the code does.
Suggested change
| // Existing members, including the accepted init member, remain. |
| interface ComponentApi { | ||
| /** Component forms this host offers to generated XMD. */ | ||
| readonly generated: Readonly<Record<string, readonly InvocationForm[]>> | undefined; | ||
| // Existing members remain. |
There was a problem hiding this comment.
Redundant comment — restates what the code does.
Suggested change
| // Existing members remain. |
PR #936: Preserve accumulated architecture guidance and review records7 files, +155 / -6 Scope🟡 Changes span 6 directories. Structural✅ No structural bloat detected. Slop
Static Analysis✅ Oxlint found no issues. CorrectnessNo extraneous code patterns detected. |
taras
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Approved architecture clarifications and agent-writing rules accumulated as local changes on the main checkout. Preserve them in a reviewable branch so future work uses the same documented guidance.
What changes
Before: the writing-for-agents guide existed only locally, and several approved documentation changes remained uncommitted.
After:
Review guide
Start with
AGENTS.mdand.agents/agent-writing.md, then review the role/rulebook changes andarchitecture.md.The branch is based on
ec4ba00378107f13bf6adcce0fad208507e4a2a7. The original checkout was 119 commits behind; changes already merged were preserved rather than copied over with older documents.How to verify it
node scripts/lint-architecture.js— passed.git diff --cached --checkbefore the scope-correction commit — passed..reviewer/paths.No product tests were run: this PR changes documentation only.
Scope
Included: accumulated repository guidance and remaining architecture clarifications.
Review artifacts under
.reviewer/, copied source trees, generated captures, logs, executable probes, binary archives, andgreeting.mdremain local. There are no product implementation, dependency, or generated build changes.Scope confirmation