Repository navigation
✨ Resume REPL entries in managed repositories and worktrees #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c8ea831
✨ Select managed repositories and worktrees in the REPL (#181, 2/6)
taras ee47d5f
🐛 Correct slot exclusion, selector ownership, recorded roots and ambi…
taras 79e42f3
🐛 Route an absolute Dir path by itself, not through the working direc…
taras 7dd9c29
🔨 Run the selection proofs only where their runtime can host them (#1…
taras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -14,11 +14,12 @@ import { homedir } from "node:os"; | |||
| import { sep } from "node:path"; | ||||
| import process from "node:process"; | ||||
| import type { Operation } from "effection"; | ||||
| import type { HelperAssembly } from "@executablemd/git/credential-helper"; | ||||
| import { installReplHost, platformDataRoot } from "./repl-assembly.ts"; | ||||
| import { useDenoReplTerminal } from "./deno-repl-terminal.ts"; | ||||
| import { useDenoReplRepositories } from "./deno-repositories.ts"; | ||||
|
|
||||
| export function* useDenoRepl(): Operation<void> { | ||||
| export function* useDenoRepl(helper: HelperAssembly): Operation<void> { | ||||
| yield* installReplHost({ | ||||
| dataRoot: () => platformDataRoot(process.platform, homedir(), process.env, sep), | ||||
| // Sixteen random bytes as hex: URL-safe, opaque, and not derived from a | ||||
|
|
@@ -28,11 +29,12 @@ export function* useDenoRepl(): Operation<void> { | |||
| appendRecord: (path, record) => appendFile(path, record), | ||||
| }); | ||||
| // What an entry's execution initializes: the recording of the File and Dir | ||||
| // work it does in the checkout the person opened the session in. Registered | ||||
| // here, in the runtime scope the selected REPL host owns, because only a | ||||
| // runtime-named module may name the native adapter — and registering it | ||||
| // acquires nothing, so a session that only reads history discovers no | ||||
| // checkout and takes no lease. | ||||
| yield* useDenoReplRepositories(); | ||||
| // work it does, and of the managed Repository and Worktree selections that | ||||
| // say where it does it. Registered here, in the runtime scope the selected | ||||
| // REPL host owns, because only a runtime-named module may name the native | ||||
| // adapter and this runtime's own credential-helper assembly — and registering | ||||
| // it acquires nothing, so a session that only reads history discovers no | ||||
| // checkout, creates no managed root and takes no lease. | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment — restates what the code does.
Suggested change
|
||||
| yield* useDenoReplRepositories(helper); | ||||
| yield* useDenoReplTerminal(); | ||||
| } | ||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant comment — restates what the code does.