Repository navigation
Conversation
PR #923: Use saved state terminology across the repository462 files, +4938 / -5022 Scope🔴 PR has 9960 lines changed. Split into focused PRs. 🟡 9960 lines changed. PRs under 400 receive more thorough review. 🟡 462 files changed. Are all changes related? 🟡 Changes span 35 directories. 🟡 PR mixes config and source changes. Structural🟡 Type declarations with no consumers: JournalAdmission, RootDocumentSource.
🟡 Interface declarations with no consumers: Planned.
Oxlint structural signals:
SlopOxlint slop signals:
Static AnalysisOxlint: 546 diagnostics across 103 files (33 rules) no-unused-vars (122): packages/git/src/deno/composition/pull-request-reads.ts, packages/git/src/deno/composition/operations.ts, packages/acp/tests/fixtures/codex-native-launch-proof.ts (+35) CorrectnessNo extraneous code patterns detected. |
Why
Use
savedconsistently for stored state throughout the repository, and prevent the previous wording from returning in prose. The cleanup includes source identifiers and filesystem paths as requested.What changes
Before:
The old terminology appeared in documentation, exported types, internal identifiers, tests, filenames and repository directories.
After:
Those names use
saved, all consumers and imports follow the new paths, and the shared banned-word list rejects the previous term through the existing prose checks. The only source occurrence is the ban entry itself.This includes the filesystem recording code delivered by #902. The branch starts from main at
60715470, after that PR merged. The 460-file diff includes 12 renamed paths across two renamed directories.Review guide
Start with:
scripts/banned-words.jsand its existing list-driven tests inscripts/tests/oxlint-policy.test.ts.Then review:
packages/durable-streams/saved.tsmodule and its exports/imports.saved-repositorydirectories in Git, their test filenames and runtime exclusion references.test-weights.json: only renamed path keys change; timing values and provenance are identical.What must stay true
How to verify it
Local subprocess checks use
DENO_DIR=/Users/tarasmankovski/Library/Caches/denoso isolated HOME fixtures can resolve the prepared cache. Terminal journeys require tmux and local socket access; the first sandboxed source attempt could not reach its socket, and its output is preserved separately.Scope
Included
Intentionally unchanged
Generated or mechanical changes
Risks and limitations
agent/terminology-cleanup; this PR refreshes that work against the merged Resume REPL entries without repeating completed file operations #902 base.CI correction verification
Revision
b68c1096corrects the site formatting, provenance checksums and fixture byte counts exposed by CI, and removes the existing #874 startup race in the permission test.deno task test scripts/tests/cloudflare-dofs-vendor.test.ts scripts/tests/acpx-vendor.test.ts packages/workflow/tests/workspace-root.test.ts: 3 tests / 19 steps pass.deno task test packages/cli/tests/repl-agent-interface.test.ts: 14 tests / 40 steps pass.deno task checkanddeno task build: pass.deno task lintanddeno task check: pass.Scope confirmation