Repository navigation
🧪 Make lifecycle and publication tests observe complete outcomes - #915
Merged
Merged
Conversation
PR #915: 🧪 Make lifecycle and publication tests observe complete outcomes9 files, +199 / -60 Scope✅ PR scope looks good. Structural✅ No structural bloat detected. Slop✅ Slop indicators look low. Static Analysis✅ Oxlint found no issues. CorrectnessNo extraneous code patterns detected. |
taras
marked this pull request as ready for review
October 15, 2026 00:25
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several passing tests do not observe the complete outcome their names promise: the REPL teardown case reads a counter copied before unwind, concurrent replacement accepts a shared text prefix, and release tests compare artifact and target names without retaining their association. This first slice of #914 makes those gaps observable.
What changes
Before: cleanup, independent subscriptions, exact publication bytes and original failure status can be missing while the selected assertions still pass. FE19's description also advertises an obsolete input alias that its programs never use.
After: tests observe the live post-unwind counter, gated producer cleanup, two producers from two subscriptions to one stream, complete submitted replacement bytes, exact release target/artifact pairs, the first failing file's original status, and exact weights replacing a preexisting file. FE19 preserves canonical text repeatability and refuses source/program before a live fragment-read sentinel fires.
What must stay true
How to verify it
Focused Deno command, passing 31 top-level tests / 202 steps:
deno task test packages/cli/tests/repl-execution.test.ts packages/core/tests/expand.test.ts packages/cli/tests/evaluate-workflow.test.ts scripts/tests/staged-write.test.ts scripts/tests/release-targets.test.ts scripts/tests/runtime-tests.test.ts scripts/tests/test-weights.test.ts scripts/tests/runtime-exclusions.test.tsTen temporary controls failed as intended: teardown release, early occurrence settlement, shared subscription, obsolete inputs performing effects before refusal, changed fresh-run output, incomplete replacement payload, swapped macOS artifacts, first filename paired with a later failure status, stale weights and inexact published bytes. Quoted/reordered YAML preserving the pairs passed. Every temporary fault was restored byte-identically before commit.
SR8 explicitly places the existing cause table outside the occurrence, matching a real execution; otherwise direct expansion's fallback scope can join a leaked producer and mask removal of the construct-owned scope.
Architect feedback: PASS for exact commit
39317e4e97281fb867eaf320583302b9b5801a4dagainst base62d1086703ec72ca6d3b6e90a596ee716c571237.Separate local delivery verification passed:
deno task lint(warnings, zero errors),deno task check,tsc --noEmit -p tsconfig.node.json, anddeno task check:jsr(Success Dry run complete). Focused Node and Bun runs each passed 172 tests across the six portable changed/affected files. Evaluate workflow and release tooling retain their existing runtime exclusions. CI owns the exhaustive runtime corpora; its status was not inspected for the feedback verdict or publication.Scope
Included
Intentionally unchanged
Scope confirmation