Bump MuTap to M3: nn_suppressor on tap::dsp::nn, pitch search in Sample - #19
Merged
Conversation
tap/MuTap#46 (96b4572), which carries DspTap 58210ae (tap/DspTap#15) as its nested pin. The learned post engine mutap.aec~ instantiates is bit-identical on the shipping v2 model in both profiles; the speech predictor's pitch search now accumulates in Sample (double profile unchanged). No source change in the externals. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JuUg1ZBxm3fyBqWgQv6H1G
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
submodules/MuTap→ tap/MuTapmainat 96b4572 (tap/MuTap#46), which carries DspTap 58210ae (tap/DspTap#15) as its nested pin. No source change in the externals.Why
The wake-word plan's M3 pass criterion: MuTap and MuTap-Max pins bumped once the learned kernels live in DspTap's
tap::dsp::nnandnn_suppressorconsumes them. This is the MuTap-Max half. The same MuTap commit also moves the speech predictor's pitch search to accumulate inSample, the root-cause fix for the Cortex-M33 finding;mutap.aec~instantiates the double profile, which is bit-for-bit unchanged by that.Verification
mutap.aec~instantiates (aec_chain_nn<double>) was shown bit-identical on the shipping v2 model against the pre-refactor binary, and the six Python parity cases pass at the M2 depths.git submodule update --init --recursivechecks out 58210ae, the squash of Add tap::dsp::nn: dense and GRU inference kernels DspTap#15).nn_suppressor::config::weightsis moved into the kernels at construction).Notes for the reviewer
submodules/MuTap1d258d3 → 96b4572, the merged tree on MuTapmain, so it stays reachable after branch cleanup. Nothing else.🤖 Generated with Claude Code
https://claude.ai/code/session_01JuUg1ZBxm3fyBqWgQv6H1G
Generated by Claude Code