Add support for POSIX shell plugin

.clang-format

@@ -10,3 +10,4 @@ QualifierOrder: [
   'const',
   'type',
 ]
+SpaceInEmptyBraces: Block

.clang-tidy

@@ -2,13 +2,13 @@ Checks: >
         -*,
         clang-diagnostic-*,
         clang-analyzer-optin.*,
-        llvm-*,-llvm-header-guard,
+        llvm-*,-llvm-header-guard,-llvm-prefer-static-over-anonymous-namespace,-llvm-use-ranges,
         google-*,-google-readability-todo,-google-readability-braces-around-statements,
         hicpp-*,-hicpp-braces-around-statements,-hicpp-use-emplace,-hicpp-named-parameter,
           -hicpp-no-array-decay,-hicpp-uppercase-literal-suffix,
         misc-*,-misc-include-cleaner,-misc-no-recursion,
         bugprone-*,
-        boost-*,
+        boost-*,-boost-use-ranges,
         cert-*,-cert-dcl16-c,-cert-dcl51-cpp,-cert-dcl37-c,
         concurrency-*,
         cppcoreguidelines-*,-cppcoreguidelines-avoid-magic-numbers,
@@ -18,6 +18,10 @@ Checks: >
         readability-*,-readability-redundant-access-specifiers
 
 CheckOptions:
+  - key:             readability-identifier-length.IgnoredVariableNames
+    value:           '^(id|it)$'
+  - key:             readability-identifier-length.IgnoredParameterNames
+    value:           '^(id|it)$'
   - key:             readability-identifier-naming.AbstractClassCase
     value:           CamelCase
   - key:             readability-identifier-naming.ClassCase

.github/workflows/build-and-test.yml

@@ -61,8 +61,12 @@ jobs:
             gtest-dev
       - name: Fixup environment
         run: |
+          # add missing final symlink for Lua library
           ln -s liblua-5.2.so.0 /usr/lib/liblua-5.2.so
+          # use ninja-build as ninja binary (alternative: install samurai instead)
           ln -s /usr/lib/ninja-build/bin/ninja /usr/bin/ninja
+          # patch Boost.process to not use ::close_range() since Alpine's musl implementation does not provide it
+          sed -i 's/#define BOOST_PROCESS_V2_HAS_CLOSE_RANGE 1/\/\/#define BOOST_PROCESS_V2_HAS_CLOSE_RANGE 1\n#include <dirent.h>/g' /usr/include/boost/process/v2/posix/detail/close_handles.ipp
         shell: alpine.sh --root {0}
 
       - name: Prepare
@@ -92,7 +96,7 @@ jobs:
           retention-days: 5
 
   unittest:
-    name: "unittest"
+    name: "unittests"
     needs: build
     runs-on: ubuntu-latest
     strategy:
@@ -151,7 +155,7 @@ jobs:
           retention-days: 3
 
   ctest:
-    name: "ctest"
+    name: "cmake tests"
     needs: build
     runs-on: ubuntu-latest
     steps:
@@ -179,8 +183,12 @@ jobs:
             gtest-dev
       - name: Fixup environment
         run: |
-          ln -s /usr/lib/ninja-build/bin/ninja /usr/bin/ninja
+          # add missing final symlink for Lua library
           ln -s liblua-5.2.so.0 /usr/lib/liblua-5.2.so
+          # use ninja-build as ninja binary (alternative: install samurai instead)
+          ln -s /usr/lib/ninja-build/bin/ninja /usr/bin/ninja
+          # patch Boost.process to not use ::close_range() since Alpine's musl implementation does not provide it
+          sed -i 's/#define BOOST_PROCESS_V2_HAS_CLOSE_RANGE 1/\/\/#define BOOST_PROCESS_V2_HAS_CLOSE_RANGE 1\n#include <dirent.h>/g' /usr/include/boost/process/v2/posix/detail/close_handles.ipp
         shell: alpine.sh --root {0}
 
       - name: Run cmake tests

.github/workflows/cpp-lint.yml

@@ -47,8 +47,12 @@ jobs:
             clang19-extra-tools
       - name: Fixup environment
         run: |
+          # add missing final symlink for Lua library
           ln -s liblua-5.2.so.0 /usr/lib/liblua-5.2.so
+          # use ninja-build as ninja binary (alternative: install samurai instead)
           ln -s /usr/lib/ninja-build/bin/ninja /usr/bin/ninja
+          # patch Boost.process to not use ::close_range() since Alpine's musl implementation does not provide it
+          sed -i 's/#define BOOST_PROCESS_V2_HAS_CLOSE_RANGE 1/\/\/#define BOOST_PROCESS_V2_HAS_CLOSE_RANGE 1\n#include <dirent.h>/g' /usr/include/boost/process/v2/posix/detail/close_handles.ipp
         shell: alpine.sh --root {0}
 
       - name: Generate compile_commands.json

CMakeLists.txt

@@ -24,7 +24,16 @@ option(PPPLUGIN_ENABLE_UNDEFINED_SANITIZE
 option(PPPLUGIN_ENABLE_UNREACHABLE_SANITIZE
        "Enable compilation with unreachable sanitize flags" OFF)
 
+# required Boost header-only components: dll, algorithm, asio, process, uuid;
+# Boost.filesystem is only required because of Boost.dll
 find_package(Boost 1.70.0 REQUIRED CONFIG COMPONENTS headers filesystem)
+if(${Boost_VERSION} VERSION_GREATER_EQUAL 1.85.0)
+  # Boost.process was header-only until 1.84; requires linking in >= 1.85
+  find_package(Boost REQUIRED CONFIG COMPONENTS process)
+else()
+  # add dummy target so that this check is only necessary once
+  add_library(Boost::process ALIAS Boost::headers)
+endif()
 find_package(Python 3.0 REQUIRED COMPONENTS Development)
 find_package(Lua 5.2 REQUIRED)
 

cmake/ppplugin-config.cmake.in

@@ -1,12 +1,18 @@
 @PACKAGE_INIT@
 
 include(CMakeFindDependencyMacro)
-find_dependency(Boost @Boost_VERSION_MAJOR@ COMPONENTS headers filesystem
-                python)
+find_dependency(Boost @Boost_VERSION_MAJOR@ CONFIG COMPONENTS headers filesystem)
+if(@Boost_VERSION@ VERSION_GREATER_EQUAL 1.85.0)
+  # Boost.process was header-only until 1.84; requires linking in >= 1.85
+  find_dependency(Boost CONFIG COMPONENTS process)
+else()
+  # add dummy target so that this check is only necessary once
+  add_library(Boost::process ALIAS Boost::headers)
+endif()
 find_dependency(Python @Python_VERSION_MAJOR@ COMPONENTS Development)
 find_dependency(Lua @LUA_VERSION_MAJOR@)
 
-if(${PPPLUGIN_ENABLE_CPP17_COMPATIBILITY})
+if(@PPPLUGIN_ENABLE_CPP17_COMPATIBILITY@)
   find_dependency(fmt @fmt_VERSION_MAJOR@)
 endif()
 

examples/CMakeLists.txt

@@ -1,6 +1 @@
-add_subdirectory(simple_plugin)
-add_subdirectory(configurable_plugin)
-add_subdirectory(lua_plugin)
-add_subdirectory(multi_language_plugin)
-add_subdirectory(multi_return_lua_plugin)
-add_subdirectory(python_plugin)
+