Skip to content

fix(deps): update dependency ip-address to v10.7.4 [security] - #5026

Closed
renovate[bot] wants to merge 3 commits into
mainfrom
renovate/npm-ip-address-vulnerability
Closed

renovate[bot] wants to merge 3 commits into
mainfrom
renovate/npm-ip-address-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
ip-address 10.7.1 → 10.7.4 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


ip-address: Address6 matches a zone identifier in quadratic time ahead of its length limit, allowing a single long string to stall the process

CVE-2026-111997 / GHSA-rxp7-6hxx-x8q5

More information

Details

Summary

new Address6() and Address6.isValid() strip a zone identifier with the pattern /%.*$/ before they apply the 45-character length limit. When the string holds many % characters followed by a line terminator, the pattern is retried from every % and each attempt scans to the line terminator before failing, so rejecting the string takes time proportional to the square of its length. 10,000 % characters and a newline take 41 ms, 40,000 take 632 ms and 100,000 take 3.9 s of synchronous work. The same strings without the newline are rejected in under a millisecond.

An application that validates an attacker-supplied string with these methods can be stalled by a single long request. The input is rejected with the correct AddressError; the cost of reaching that rejection is the defect.

Details

The constructor in src/ipv6.ts removes the CIDR suffix, then the zone, then checks the length of what is left:

const zone = constants6.RE_ZONE_STRING.exec(address);

if (zone) {
  this.zone = zone[0];

  address = address.replace(constants6.RE_ZONE_STRING, '');
}

const longest = this.groups * 5 + 5;

if (address.length > longest) {
  throw new AddressError(`IPv6 addresses are at most ${longest} characters.`);
}

RE_ZONE_STRING is /%.*$/. It has no anchor at its start, . does not match a line terminator (\n, \r, U+2028 or U+2029), and without the m flag $ matches only at the end of the input. For % repeated N times and then \n, the engine starts a match at the first %, .* consumes the remaining % characters up to the newline, $ fails there, and backtracking through every shorter .* fails too. The engine then starts again at the second %, and so on: N starts, each proportional to N. The length limit that follows rejects the string in constant time, after the scan has already run.

The line terminator need not be last. Any string in which many % characters precede a line terminator behaves the same way.

Every entry point that passes a caller's string to the Address6 constructor is affected: new Address6(), isValid(), both arguments of fromAddressAndMask() and fromAddressAndWildcardMask(), and the prefix argument of fromAddress4Nat64() and toAddress4Nat64(). fromWildcard() rejects a % before it constructs anything, fromURL() admits only hex digits, colons and dots in a host, and fromArpa() checks the nibble grammar first, so those three are unaffected. Address4 has no zone and is unaffected.

Affected versions

<= 10.7.3. The zone pattern has been in the constructor since 1.0.0; 5.9.4, 9.0.5 and 10.7.0 show the same timings as 10.7.3.

Impact

Address6.isValid() on N % characters and a newline, measured on ip-address 10.7.3 and node 24.21.0:

Input Wall time Same length of !
5,461 characters 13 ms 0.1 ms
16 KiB 108 ms 0.1 ms
100 KB 3.9 s 0.1 ms
256 KiB 27 s 0.2 ms

The parse is synchronous, so the event loop is blocked for the whole of the wall time and nothing else on that process is served. No memory is retained and the process resumes when the call returns.

Reachability

The input needs a line terminator after the % characters, which decides where it can arrive. An HTTP header value cannot carry a carriage return or a line feed, so a host or address taken from a header does not reach this. A URL can carry both characters percent-encoded at three bytes each, and Node's default 16 KB limit on the request line and headers admits about 5,461 of them: 13 ms. A request body is where the larger sizes come from. Common body parsers default to between 100 KB and 1 MB, and at 100 KB one field passed to the parser unchecked blocks the process for 3.9 s.

Proof of concept

npm i ip-address@10.7.3, then:

const { Address6 } = require('ip-address');

function time(input) {
  const start = process.hrtime.bigint();

  Address6.isValid(input);

  return `${(Number(process.hrtime.bigint() - start) / 1e6).toFixed(1)} ms`;
}

for (const n of [10000, 20000, 40000, 100000]) {
  console.log(`${n}: ${time(`${'%'.repeat(n)}\n`)}, without the newline ${time('%'.repeat(n))}`);
}

On affected versions (node 24.21.0):

10000: 41.0 ms, without the newline 0.0 ms
20000: 161.1 ms, without the newline 0.0 ms
40000: 632.4 ms, without the newline 0.1 ms
100000: 3899.8 ms, without the newline 0.1 ms

Each doubling of the input multiplies the time by four.

Remediation

Upgrade to the patched release. In the fix, the constructor finds the zone by the index of the first % and accepts the remainder as a zone only when it holds no line terminator, which reads the input once. 1 MiB of the input above is rejected in about a millisecond. Every address that parsed before parses to the same result, and a string with a line terminator after a % is rejected as it was.

RE_ZONE_STRING stays exported from v6/constants for code that imports it directly and is marked @deprecated; the library itself does not call it.

If you cannot upgrade immediately, reject a candidate longer than an address with a zone identifier can be before you parse it:

if (host.length > 64) throw new Error('not an IP address');

Severity

  • CVSS Score: 6.3 / 10 (Medium)
  • Vector String: CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:N

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Release Notes

beaugunderson/ip-address (ip-address)

v10.7.4

Compare Source

Full Changelog: beaugunderson/ip-address@v10.7.3...v10.7.4

v10.7.3

Compare Source

What's Changed

Full Changelog: beaugunderson/ip-address@v10.7.2...v10.7.3

v10.7.2

Compare Source

What's Changed

Full Changelog: beaugunderson/ip-address@v10.7.1...v10.7.2


Configuration

📅 Schedule: (in timezone Europe/Zurich)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot force-pushed the renovate/npm-ip-address-vulnerability branch from d7eb275 to f9206e5 Compare October 30, 2026 10:46
@tale-code-bot tale-code-bot mentioned this pull request Oct 30, 2026
59 tasks
@renovate
renovate Bot force-pushed the renovate/npm-ip-address-vulnerability branch from f9206e5 to e519a63 Compare November 5, 2026 17:01
@tale-code-bot tale-code-bot added the bug Bug label Nov 7, 2026
The services/sandbox workspace entry still pinned ip-address 10.7.1, so bun install --frozen-lockfile in the sandbox image failed with "lockfile had changes".
The sandbox image installs with bun install --frozen-lockfile from its own bun.lock, which still pinned ip-address 10.7.1 after services/sandbox/package.json moved to 10.7.4. Regenerated with bun 1.4.2 (the Dockerfile's version); only the ip-address entries change.
@renovate

renovate Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

yannickmonney added a commit that referenced this pull request Nov 8, 2026
Squashed from #5026 (head 68be83d). The sandbox image installs frozen from services/sandbox/bun.lock, so that lock moves with its manifest.
@yannickmonney

Copy link
Copy Markdown
Contributor

Landed on train as cd8fe29 (squashed from head 68be83d). It reaches main with the next train pull request.

@renovate

renovate Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (10.7.4). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate
renovate Bot deleted the renovate/npm-ip-address-vulnerability branch November 8, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants