Skip to content

fix(session): detect finished turns again on Claude Code 2.1.319 - #119

Merged
talayash merged 1 commit into
masterfrom
fix/session-completion-detection
Nov 8, 2026
Merged

talayash merged 1 commit into
masterfrom
fix/session-completion-detection

Conversation

@talayash

@talayash talayash commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Problem

Since v1.42.0, a finished session raises no notification, no sound, and no "Response ready" state.

Cause

Claude Code draws its input-box rules (────) exactly as wide as the terminal, so xterm flags the next row (the ❯ prompt, the footer) as wrapped. readBufferTail (added in 1a4d634) joins wrapped rows, so the prompt was glued onto the rule and hasReadyPrompt never matched. The turn was never counted as completed.

Fix

readBufferTail no longer joins a row onto a line that is only a horizontal rule. Real wrapped text is still joined.

Verification

  • New test in terminalScreen.test.ts using the screen captured from Claude Code 2.1.319: fails before, passes after.
  • npx vitest run src/lib src/hooks/useSessionStateDetection.test.ts src/components/insight: 842/842 pass. npx tsc --noEmit clean.
  • Live QA instance: before, hasReadyPrompt false and attention never pending; after, attention pending and the sidebar shows "Response ready".

Generated with Claude Code

Claude Code draws its input-box rules exactly as wide as the terminal, so
xterm flags the row after each rule (the `❯` prompt, the footer) as wrapped.
readBufferTail joined wrapped rows, glued the prompt onto the rule, and
hasReadyPrompt never matched: a finished turn was never "completed", so no
notification, sound or "Response ready" state was raised (since v1.42.0).

readBufferTail no longer joins a row onto a line that is only a horizontal
rule. Real wrapped text is still joined.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ecc-tools

ecc-tools Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / Security Evidence

Commit: 53b9b4fa4ae086d54744ae2084e87f5b1d1ead15

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 2 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / PR Risk Taxonomy

Commit: 53b9b4fa4ae086d54744ae2084e87f5b1d1ead15

PR taxonomy review recommended (neutral)

Detected 1 PR taxonomy bucket(s): CI/CD Recommendation.

Scanned 2 changed file(s).

Roadmap taxonomy buckets:

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • 1 CI or workflow path(s) changed

Paths:

  • src/lib/terminalScreen.test.ts

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / Reference Set Readiness

Commit: 53b9b4fa4ae086d54744ae2084e87f5b1d1ead15

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 2 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

ECC Tools / Hosted Promotion Readiness

Commit: 53b9b4fa4ae086d54744ae2084e87f5b1d1ead15

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 2 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@talayash
talayash merged commit bde85d4 into master Nov 8, 2026
4 checks passed
@talayash
talayash deleted the fix/session-completion-detection branch November 8, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant