Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces containerization and automated publishing to GitHub Container Registry (GHCR) for ts-plug, enabling multi-arch (amd64/arm64) builds and CI-based image publishing.
Changes:
- Add a multi-stage Dockerfile that builds a static
ts-plugbinary and ships it in a minimal Alpine runtime image. - Add a GitHub Actions workflow to build (and on non-PR events, push) the image to GHCR with metadata-driven tags/labels.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Multi-stage, multi-arch build producing a minimal Alpine runtime image with ts-plug entrypoint. |
| .github/workflows/build-image.yaml | CI workflow to build/push the Docker image to GHCR and generate tags/labels via docker/metadata-action. |
Suppressed comments (1)
.github/workflows/build-image.yaml:52
- The computed tag set doesn’t match the workflow header comment/PR description:
type=ref,event=branchwill publish an extramaintag on pushes to main.- There’s no tag rule that would publish
v1.2.3(as-is tag name). latestis currently only enabled for the default branch, so it won’t be published for release/tag builds.
Consider switching totype=ref,event=tagfor thev*tag, and makelatestunconditional (or otherwise enabled for tag/release runs) so the published tags match the stated intent.
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Multi-arch Dockerfile: Go cross-compiles on BUILDPLATFORM (no QEMU) into a static binary, alpine runtime stage. ca-certificates are copied from the builder rather than installed on the runtime stage so the target-arch layer only has COPY instructions. Workflow publishes to GHCR on: * push to main -> latest, sha-<sha> * push of a v*.*.* tag -> 1.2.3, 1.2, 1, sha-<sha> * pull request against main -> build only, smoke test * manual workflow_dispatch -> latest, sha-<sha> latest tracks main by design; version tags land as their semver form without the v prefix (docker/metadata-action default). Signed-off-by: Justin Garrison <justinleegarrison@gmail.com>
rothgar
force-pushed
the
feature/dockerfile
branch
from
August 13, 2026 23:15
ad13ff0 to
41df43e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow publishes ghcr.io/:latest on every push to main and proper semver tags (v1.2.3, 1.2, 1) on releases.