ts_{ov,und}erlay_router: move to ts_dataplane - #425
Merged
Merged
Conversation
npry
force-pushed
the
npry/refactor.routers
branch
from
September 21, 2026 15:17
e10c4b7 to
524bf29
Compare
npry
marked this pull request as ready for review
September 21, 2026 15:17
npry
requested review from
danderson,
dylan-tailscale and
nrc
as code owners
September 21, 2026 15:17
dylan-tailscale
approved these changes
Sep 21, 2026
dylan-tailscale
left a comment
dylan-tailscale
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, one non-blocking naming suggestion
| @@ -0,0 +1,4 @@ | |||
| //! Overlay router components. | |||
Collaborator
There was a problem hiding this comment.
Loosely-held opinion: or and ur are a bit too terse for my liking, although I definitely agree with the principle. Would overlay and underlay work as mod names, albeit not as terse/specific to routing? Soft preference, nbd if you prefer or/ur.
Member
Author
There was a problem hiding this comment.
Just maintaining what was there before — iirc @danderson named the former crate reexports this way originally. I think I probably prefer just overlay_router and underlay_router -- given we concur re: terseness I'll do that
npry
force-pushed
the
npry/refactor.routers
branch
from
September 21, 2026 17:47
524bf29 to
944c834
Compare
These were pretty minimal crates which are essential parts of the dataplane and really belong there: merge them into dataplane as modules. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Ie864b815024ad3cd9fe0b3d7fca5f1866a6a6964
npry
force-pushed
the
npry/refactor.routers
branch
from
September 21, 2026 18:03
944c834 to
3b0b74f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were pretty minimal crates which are essential parts of the dataplane and really belong there: merge them into dataplane as modules.