Conversation
Justification: TUN devices aren't on our roadmap anytime soon, this is a holdover from ~a year ago. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I59355314f003d85f329cb25b952f5d4f6a6a6964
npry
requested review from
danderson,
dylan-tailscale and
nrc
as code owners
September 21, 2026 14:38
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Ic7d17a7297d39fd986ff5af3835d6e926a6a6964
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I06a6bdd98e186a742f58b296613c5ed96a6a6964
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I2ace6020fea2e748925451f64935c5dc6a6a6964
npry
force-pushed
the
npry/refactor.util
branch
from
September 21, 2026 15:13
f83d437 to
f7bcc3e
Compare
dylan-tailscale
approved these changes
Sep 21, 2026
dylan-tailscale
left a comment
dylan-tailscale
left a comment
Collaborator
There was a problem hiding this comment.
One nit, one question, otherwise lgtm - thanks!!
| use super::*; | ||
|
|
||
| #[test] | ||
| fn ascii_for_byte() { |
Collaborator
There was a problem hiding this comment.
Question: what's the motivation for these becoming tests instead of examples? I'm totally fine with it here (they're not really useful this deep in our codebase), but interested if there's a rule or general vibe I've missed here, or if it's just because those functions aren't publicly accessible outside the crate.
|
|
||
| [policy.ts_underlay_router] | ||
| audit-as-crates-io = false | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| [policy.ts_util] | |
| audit-as-crates-io = false | |
Needs a policy.ts_util section for the new crate
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
ts_future_utilandts_hexdumpinto a singlets_utilcrate as we discussed in sync last (?) week, with functionality gated by feature flags.Also snuck in the deletion of
ts_transport_tun, since it's unused and we haven't touched it for a long time/to my knowledge have no imminent plans to do so.