Conversation
AddAllowedClient could add a key while running but nothing could take one back: revoking a client meant restarting serve with a shorter --allow, which also drops every other client until they re-meow. RemoveAllowedClient deletes the key from the allowlist and, if the client is connected, drops it from the network map so its tunnel is torn down. Client IDs now come from a counter instead of len(clients)+2, which would collide with a live peer after a removal. Fixes tailscale#124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart of AddAllowedClient: revoke a key while the server runs, and drop the client if it is connected, instead of restarting serve and disconnecting everyone. Verified in the new test that a revoked client's dial fails within seconds, so no engine-level peer eviction was needed.
Fixes #124