Repository navigation
fix(deps): update dependency @clack/prompts to v1.8.1 - #2382
Conversation
🦋 Changeset detectedLatest commit: 4640926 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@tailor-platform/create-sdk
@tailor-platform/eslint-plugin-sdk
@tailor-platform/sdk
@tailor-platform/sdk-plugin-seed
@tailor-platform/sdk-plugin-setup
@tailor-platform/sdk-plugin-tailordb-erd
commit: |
🤖 Claude Dependency Review✅ Recommended ActionsNone — safe to merge as-is. This is a patch release fixing a TypeScript type definition without any breaking changes or security concerns. 📦 Update Summary
📝 Release NotesType Definition Fix:
Dependency Update:
🔐 Security Assessment
Sources: 🚨 Breaking ChangesNone. This is a patch release with no breaking changes. ✨ Main ChangesType Safety Improvement: Benefits:
Context from Version 1.8.0: 🔍 Impact Analysis📁 Usage Locations
SummaryAll usage locations are safe. The type fix enhances TypeScript type safety without requiring any code changes. The existing cancellation handling pattern ( |
This comment has been minimized.
This comment has been minimized.
|
@copilot fix ci |
Co-authored-by: toiroakr <3090700+toiroakr@users.noreply.github.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This comment has been minimized.
This comment has been minimized.
|
@copilot resolve the merge conflicts in this pull request |
…s-1.x # Conflicts: # pnpm-lock.yaml Co-authored-by: toiroakr <3090700+toiroakr@users.noreply.github.com>
…ptResult TypeScript cannot narrow a conditional return type tied to a generic parameter via control-flow analysis, so the previous `Exclude<T, symbol>` signature required an `as` cast. Both call sites resolve to string, so pinning the parameter/return types to the concrete `string | symbol` union lets the narrowing work without the cast.
… renovate/clack-prompts-1.x
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile contains a critical dependency snapshot inconsistency that must be corrected.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates @clack/prompts from 1.8.0 to 1.8.1 and aligns prompt-result typing in the scaffolding CLI.
Changes:
- Updates dependency and lockfile entries.
- Refines prompt cancellation typing.
- Adds patch changesets.
File summaries
| File | Summary |
|---|---|
pnpm-lock.yaml |
Critical: The @politty/zod snapshot key references zod@4.6.4 while the importer resolves zod@4.6.5; frozen installs may fail. Correct the snapshot key. |
packages/create-sdk/src/context.ts |
Adjusts prompt-result typing. |
packages/create-sdk/package.json |
Updates @clack/prompts. |
.changeset/renovate-2382.md |
Adds the dependency changeset. |
.changeset/create-sdk-unwrap-prompt-result.md |
Adds the CLI typing changeset. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
…xes the typing @clack/prompts 1.8.0 widened the prompt return types from `Value | typeof CANCEL_SYMBOL` to `Value | symbol`, which defeated the `isCancel` type guard and forced the `unwrapPromptResult` / `requireValue` workaround in #2332. 1.8.1 restores the narrow return types, so `packages/create-sdk/src/context.ts` goes back to its pre-workaround form. Also fix the `@politty/zod` snapshot key in the lockfile: the importers resolve `zod@4.6.5` while the snapshot only defined the `zod@4.6.4` variant, which left the package unmaterialized and broke typecheck. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hhr3H8hC7Z1sSfSd1diYBT
`@tailor-platform/sdk` and `@tailor-platform/create-sdk` are a fixed version group, so the renovate changeset already releases create-sdk. The prompt-cancellation revert is invisible to users and does not need its own CHANGELOG entry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hhr3H8hC7Z1sSfSd1diYBT
Code Metrics Report (packages/sdk)
Details | | main (0f70ef8) | #2382 (6b83c00) | +/- |
|--------------------|----------------|-----------------|------|
| Coverage | 84.1% | 84.1% | 0.0% |
| Files | 528 | 528 | 0 |
| Lines | 21600 | 21600 | 0 |
| Covered | 18173 | 18173 | 0 |
| Code to Test Ratio | 1:0.5 | 1:0.5 | 0.0 |
| Code | 167121 | 167121 | 0 |
| Test | 89056 | 89056 | 0 |SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
This PR contains the following updates:
1.8.0→1.8.1Release Notes
bombshell-dev/clack (@clack/prompts)
v1.8.1Compare Source
Patch Changes
8bd9129Thanks @gameroman! - Return type for prompts now correctly specifiesCANCEL_SYMBOLinstead ofsymbolUpdated dependencies [
8bd9129]:Configuration
📅 Schedule: (in timezone Asia/Tokyo)
* 9-18 * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.