Skip to content

fix(deps): update dependency @clack/prompts to v1.8.1 - #2382

Merged
toiroakr merged 9 commits into
mainfrom
renovate/clack-prompts-1.x
Sep 18, 2026
Merged

toiroakr merged 9 commits into
mainfrom
renovate/clack-prompts-1.x

Conversation

@renovate

@renovate renovate Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
@clack/prompts (source) 1.8.0 → 1.8.1 age confidence

Release Notes

bombshell-dev/clack (@​clack/prompts)

v1.8.1

Compare Source

Patch Changes

Configuration

📅 Schedule: (in timezone Asia/Tokyo)

  • Branch creation
    • Between 09:00 AM and 06:59 PM, Monday through Friday (* 9-18 * * 1-5)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from a team as a code owner September 17, 2026 03:01
@changeset-bot

changeset-bot Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4640926

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@tailor-platform/sdk Patch
@tailor-platform/create-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tailor-platform-pr-trigger
tailor-platform-pr-trigger Bot requested a review from a team as a code owner September 17, 2026 03:01
@pkg-pr-new

pkg-pr-new Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@tailor-platform/create-sdk

pnpm add https://pkg.pr.new/tailor-platform/sdk/@tailor-platform/create-sdk@4640926

@tailor-platform/eslint-plugin-sdk

pnpm add https://pkg.pr.new/tailor-platform/sdk/@tailor-platform/eslint-plugin-sdk@4640926

@tailor-platform/sdk

pnpm add https://pkg.pr.new/tailor-platform/sdk/@tailor-platform/sdk@4640926

@tailor-platform/sdk-plugin-seed

pnpm add https://pkg.pr.new/tailor-platform/sdk/@tailor-platform/sdk-plugin-seed@4640926

@tailor-platform/sdk-plugin-setup

pnpm add https://pkg.pr.new/tailor-platform/sdk/@tailor-platform/sdk-plugin-setup@4640926

@tailor-platform/sdk-plugin-tailordb-erd

pnpm add https://pkg.pr.new/tailor-platform/sdk/@tailor-platform/sdk-plugin-tailordb-erd@4640926

commit: 4640926

@github-actions

Copy link
Copy Markdown

🤖 Claude Dependency Review

✅ Recommended Actions

None — safe to merge as-is. This is a patch release fixing a TypeScript type definition without any breaking changes or security concerns.

📦 Update Summary

  • Library: @​clack/prompts
  • Version: 1.8.0 → 1.8.1
  • Change Type: Patch
📝 Release Notes

1.8.1 Changelog

Type Definition Fix:

  • Return type for prompts now correctly specifies CANCEL_SYMBOL instead of symbol
  • This addresses a type annotation issue introduced in version 1.8.0

Dependency Update:

  • @​clack/core updated to 1.5.1
🔐 Security Assessment
  • Risk: 🟢 Low
  • Known vulnerabilities: None found. No CVEs or GHSAs reported for versions 1.8.0 or 1.8.1
  • Supply-chain notes: None. The package is well-established with 289 million downloads, maintained by the bombshell-dev team, and has no security advisories in GitHub Advisory Database, Snyk, OSV, or ReversingLabs databases

Sources:

🚨 Breaking Changes

None. This is a patch release with no breaking changes.

✨ Main Changes

Type Safety Improvement:
The update fixes a TypeScript type definition issue where prompt functions previously returned the generic symbol type to indicate cancellation. The return type now correctly specifies CANCEL_SYMBOL, which is the actual constant exported by the library.

Benefits:

  • More precise type checking in TypeScript
  • Better IDE autocomplete and type inference
  • No runtime behavior changes

Context from Version 1.8.0:
Version 1.8.0 introduced the CANCEL_SYMBOL export and new features (tab-completion for path prompts, async validation). Version 1.8.1 corrects the type annotation to properly reflect the cancellation symbol in return types.

🔍 Impact Analysis

📁 Usage Locations

@​clack/prompts is used in the following 4 files:

  1. packages/create-sdk/src/context.ts

    import { cancel, log, select, text } from "@​clack/prompts";
    • Features used:
      • text() prompt for project name input (lines 99-102)
      • select() prompt for template selection (lines 114-117)
      • cancel() function for handling user cancellation (line 66)
      • log utilities for info/error messages
    • Impact: ✅ No breaking changes. The existing code uses typeof value === "symbol" check in unwrapPromptResult (line 64-69), which correctly handles both the old and new type. The type fix actually improves type safety for this pattern.
  2. packages/create-sdk/src/copy.ts

    import { spinner } from "@​clack/prompts";
    • Features used: spinner() for loading state during file copy operations (lines 21-38)
    • Impact: ✅ No changes needed. Spinner API is unaffected by the type fix.
  3. packages/create-sdk/src/index.ts

    import { intro, outro } from "@​clack/prompts";
    • Features used: intro() and outro() for CLI welcome/goodbye messages (lines 29, 42)
    • Impact: ✅ No changes needed. These APIs are unaffected by the type fix.
  4. packages/create-sdk/src/init.ts

    import { log, spinner } from "@​clack/prompts";
    • Features used:
      • log utilities for info/warn messages (lines 25, 32, 43)
      • spinner() for loading states during installation and git init (lines 27-30, 36-41)
    • Impact: ✅ No changes needed. These APIs are unaffected by the type fix.

Summary

All usage locations are safe. The type fix enhances TypeScript type safety without requiring any code changes. The existing cancellation handling pattern (typeof value === "symbol") in context.ts works correctly and will benefit from the improved type precision.


@github-actions

This comment has been minimized.

@toiroakr

Copy link
Copy Markdown
Contributor

@copilot fix ci

Co-authored-by: toiroakr <3090700+toiroakr@users.noreply.github.com>

Copilot AI commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@copilot fix ci

Fixed in d2e35f2. I updated the create-sdk prompt result helper to narrow the new @clack/prompts cancel-symbol return type, and the affected package now passes typecheck, lint, and build locally.

@renovate

renovate Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@github-actions

This comment has been minimized.

@toiroakr

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

…s-1.x

# Conflicts:
#	pnpm-lock.yaml

Co-authored-by: toiroakr <3090700+toiroakr@users.noreply.github.com>

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in a5dd33b. I merged main into this branch, fixed the pnpm-lock.yaml conflict by preserving both the @clack/prompts 1.8.1 update and main’s newer dependency state, and pushed the merge commit.

…ptResult

TypeScript cannot narrow a conditional return type tied to a generic
parameter via control-flow analysis, so the previous `Exclude<T, symbol>`
signature required an `as` cast. Both call sites resolve to string, so
pinning the parameter/return types to the concrete `string | symbol`
union lets the narrowing work without the cast.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The lockfile contains a critical dependency snapshot inconsistency that must be corrected.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates @clack/prompts from 1.8.0 to 1.8.1 and aligns prompt-result typing in the scaffolding CLI.

Changes:

  • Updates dependency and lockfile entries.
  • Refines prompt cancellation typing.
  • Adds patch changesets.
File summaries
File Summary
pnpm-lock.yaml Critical: The @politty/zod snapshot key references zod@4.6.4 while the importer resolves zod@4.6.5; frozen installs may fail. Correct the snapshot key.
packages/create-sdk/src/context.ts Adjusts prompt-result typing.
packages/create-sdk/package.json Updates @clack/prompts.
.changeset/renovate-2382.md Adds the dependency changeset.
.changeset/create-sdk-unwrap-prompt-result.md Adds the CLI typing changeset.
Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file
  • Files reviewed: 4/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pnpm-lock.yaml Outdated
@github-actions

This comment has been minimized.

@remiposo remiposo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the workaround introduced when upgrading to 1.8.0 is no longer necessary due to the fix in 1.8.1. Wouldn't it be correct to remove the added helper and revert back to isCancel?
#2332

…xes the typing

@clack/prompts 1.8.0 widened the prompt return types from
`Value | typeof CANCEL_SYMBOL` to `Value | symbol`, which defeated the
`isCancel` type guard and forced the `unwrapPromptResult` / `requireValue`
workaround in #2332. 1.8.1 restores the narrow return types, so
`packages/create-sdk/src/context.ts` goes back to its pre-workaround form.

Also fix the `@politty/zod` snapshot key in the lockfile: the importers
resolve `zod@4.6.5` while the snapshot only defined the `zod@4.6.4`
variant, which left the package unmaterialized and broke typecheck.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hhr3H8hC7Z1sSfSd1diYBT
`@tailor-platform/sdk` and `@tailor-platform/create-sdk` are a fixed
version group, so the renovate changeset already releases create-sdk.
The prompt-cancellation revert is invisible to users and does not need
its own CHANGELOG entry.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hhr3H8hC7Z1sSfSd1diYBT
@github-actions

Copy link
Copy Markdown

Code Metrics Report (packages/sdk)

main (0f70ef8) #2382 (6b83c00) +/-
Coverage 84.1% 84.1% 0.0%
Code to Test Ratio 1:0.5 1:0.5 0.0
Details
  |                    | main (0f70ef8) | #2382 (6b83c00) | +/-  |
  |--------------------|----------------|-----------------|------|
  | Coverage           |          84.1% |           84.1% | 0.0% |
  |   Files            |            528 |             528 |    0 |
  |   Lines            |          21600 |           21600 |    0 |
  |   Covered          |          18173 |           18173 |    0 |
  | Code to Test Ratio |          1:0.5 |           1:0.5 |  0.0 |
  |   Code             |         167121 |          167121 |    0 |
  |   Test             |          89056 |           89056 |    0 |

SDK Configure Bundle Size

main (0f70ef8) #2382 (6b83c00) +/-
configure-index-size 13.52KB 13.52KB 0KB
dependency-chunks-size 23.36KB 23.36KB 0KB
total-bundle-size 36.88KB 36.88KB 0KB

Runtime Performance

main (0f70ef8) #2382 (6b83c00) +/-
Generate Median 1,850ms 1,844ms -6ms
Generate Max 1,871ms 1,877ms +6ms
Apply Build Median 2,001ms 1,986ms -15ms
Apply Build Max 2,028ms 1,996ms -32ms

Type Performance (instantiations)

main (0f70ef8) #2382 (6b83c00) +/-
tailordb-basic 47,966 47,966 0
tailordb-optional 4,768 4,768 0
tailordb-relation 4,840 4,840 0
tailordb-validate 694 694 0
tailordb-hooks 5,833 5,833 0
tailordb-object 13,762 13,762 0
tailordb-enum 1,619 1,619 0
resolver-basic 12,618 12,618 0
resolver-nested 35,917 35,917 0
resolver-array 24,554 24,554 0
executor-schedule 4,489 4,489 0
executor-webhook 1,130 1,130 0
executor-record 5,443 5,443 0
executor-resolver 6,306 6,306 0
executor-operation-function 1,118 1,118 0
executor-operation-gql 1,126 1,126 0
executor-operation-webhook 1,137 1,137 0
executor-operation-workflow 1,931 1,931 0

Reported by octocov

@toiroakr
toiroakr merged commit 3c2ef2c into main Sep 18, 2026
49 checks passed
@toiroakr
toiroakr deleted the renovate/clack-prompts-1.x branch September 18, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants