Skip to content

fix(select): add inner padding to the dropdown - #607

Open
IzumiSy wants to merge 1 commit into
mainfrom
fix/select-dropdown-padding
Open

IzumiSy wants to merge 1 commit into
mainfrom
fix/select-dropdown-padding

Conversation

@IzumiSy

@IzumiSy IzumiSy commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Motivation

The Select popup has no inner padding, so highlighted options touch its edges. Menu, Combobox, and Autocomplete already provide a 4px inset.

Extract the Select-only fix described by .changeset/snug-lists-breathe.md from #560 so it can be reviewed and released independently of DataTable inline editing. The source PR remains unchanged.

Summary

  • Add 4px inner padding to the Select popup, matching the other dropdown components.
  • Update the three affected Select snapshots while preserving the current main-branch rendering.
  • Include the original patch changeset; no DataTable changes or public API changes are included.

The Select popup had no inner padding, so a highlighted option touched
its edges. It now has the same 4px inset as Menu, Combobox and
Autocomplete.

Refs tailor-inc/platform-planning#1750

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e7b094f)
@github-actions

Copy link
Copy Markdown
Contributor

Code Metrics Report

main (06c59b8) #607 (765dc79) +/-
Coverage 88.9% 88.9% 0.0%
Test Execution Time 2m12s 1m36s -36s
Details
  |                     | main (06c59b8) | #607 (765dc79) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          88.9% |          88.9% | 0.0% |
  |   Files             |            209 |            209 |    0 |
  |   Lines             |           6316 |           6316 |    0 |
  |   Covered           |           5616 |           5616 |    0 |
+ | Test Execution Time |          2m12s |          1m36s | -36s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/- Status
packages/core/src/components/select/select.tsx 100.0% 0.0% modified

Reported by octocov

@IzumiSy
IzumiSy marked this pull request as ready for review October 15, 2026 02:00
@IzumiSy
IzumiSy requested a review from a team as a code owner October 15, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants