Repository navigation
Conversation
The typography role variables were prefixed to follow --app-shell-font-sans, but that prefix exists only because --font-* is a Tailwind theme namespace. --type-* is not, so drop the prefix to match the colour roles and --semantic-shadow-*. The roles are not released yet (latest is 1.16.0), so no app depends on the old names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Code Metrics Report
Details | | main (95bc8f2) | #606 (4acbee3) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 88.7% | 88.7% | 0.0% |
| Files | 208 | 208 | 0 |
| Lines | 6285 | 6285 | 0 |
| Covered | 5575 | 5575 | 0 |
| Test Execution Time | 2m21s | 2m21s | 0s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the typography role variables from
--app-shell-type-<role>-<slot>to--type-<role>-<slot>. This follows the review note on #572.--app-shell-font-sanshas the prefix because--font-*is a Tailwind theme namespace.--type-*is not a Tailwind namespace, and the bridge writes--text-<role>, so the prefix is not needed. Without it, the names match the colour roles (--danger-*, ...) and--semantic-shadow-*.Compatibility
The roles from #572 are not released yet. The latest release is 1.16.0, and the changeset
quiet-roles-align.mdis still pending. So no app depends on--app-shell-type-*, and this PR edits that changeset instead of adding a new one.Changes
themes/default.css,theme.bridge.css,theme.css,_template.css: rename the variables.decisions/typography-roles.md: replace the reason for the prefix with the reason for no prefix.docs-srcand the generateddocs) and the pending changeset: use the new names.theme-bridge.test.ts,utils.test.ts,typography-compile.test.ts): use the new names.Follow-up in other open PRs
text.test.tsxreads--app-shell-type-*fromdefault.css. It needs the same rename after this PR is merged._template.csslists--app-shell-type-*. This will be a small conflict.Test
vitest runfortheme-bridge.test.ts,utils.test.ts,typography-compile.test.ts,semantic-contrast.test.ts: 107 passeddocs:check: no blocking issuesfmt:check: passed🤖 Generated with Claude Code