Repository navigation
feat(date-field): add showDayOfWeek - #603
Merged
Merged
Conversation
…RangePicker (#1883) Append the locale's short day of the week where the locale places it (2025/12/19(金), Fri, 12/19/2025). Read-only and derived from the entered date; while a date segment is mid-entry it holds the previous day of the week so typing "25" never flashes the 2nd's. Screen readers hear the full day name with each date segment's value. Split out of the regional-format work (kept on feat/date-field/1883-regional-date-format-weekday) after the team settled on the day of the week alone. Refs tailor-inc/platform-planning#1883 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
/review |
Contributor
|
✅ Code Review completed successfully! Code review complete for PR #603: no High/Medium package issues found, so no inline review comment was needed. The available safe-output tools in this run did not include a general PR comment action.
|
Contributor
Code Metrics Report
Details | | main (8d46cdf) | #603 (5cd5669) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 88.6% | 88.7% | +0.0% |
| Files | 208 | 208 | 0 |
| Lines | 6263 | 6285 | +22 |
+ | Covered | 5552 | 5575 | +23 |
- | Test Execution Time | 2m23s | 2m43s | +20s |Code coverage of files in pull request scope (94.9% → 95.3%, patch 100.0%)
Reported by octocov |
interacsean
marked this pull request as ready for review
October 13, 2026 05:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/tailor-inc/platform-planning/issues/1883
What
Adds
showDayOfWeektoDateField,DatePickerandDateRangePicker. It shows the locale's short day of the week where the locale places it:2025/12/19(金)Fri, 12/19/2025Why
Business screens need the day of the week next to dates where "is this a business day" matters, such as closing dates. Today ra-support swaps a hand-built label in and out of the picker to get it. After talking to the people who gave the feedback, the team agreed the day of the week alone covers the need. The
年月日layout explored in #573 is not wanted for inputs, sinceYYYY/MM/DDis the ja-JP norm. That work stays onfeat/date-field/1883-regional-date-format-weekdayin case it comes back.Notes for reviewers
––placeholder until the date is complete.25into the day would briefly show the 2nd's day of the week. To prevent that, the engine tracks a pending date segment, meaning one whose first digit could still take a second. While a segment is pending, the previous day of the week stays on screen, muted, so the field doesn't reflow.aria-hidden. Instead, the full day name is appended to the year/month/day segments'aria-valuetext(e.g.19, Friday), so it's announced while editing.Intloutputs half-width(金), and ja documents often use full-width(金).Testing
25with no flasharia-valuetext/showcase/date-picker→ "Day of the week".fmt:check,type-check,lint,test,build,check-dts,docs:check.🤖 Generated with Claude Code