Repository navigation
test(core): extract test harness cleanup - #600
Merged
Merged
Conversation
IzumiSy
marked this pull request as ready for review
October 13, 2026 03:31
Contributor
Code Metrics Report
Details | | main (d8d4ec3) | #600 (3ce3e11) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 88.6% | 88.6% | 0.0% |
| Files | 208 | 208 | 0 |
| Lines | 6263 | 6263 | 0 |
| Covered | 5552 | 5552 | 0 |
+ | Test Execution Time | 1m53s | 1m46s | -7s |Reported by octocov |
interacsean
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #525 combines an oxlint upgrade, production state-ownership changes, a DataTable API addition, and test cleanup. Reviewing those concerns together makes it difficult to distinguish mechanical changes from behavior changes.
This PR extracts only the independently mergeable test cleanup onto the latest
main, as the first step toward landing the larger change incrementally. It does not require the compiler-oriented production refactors or the newer lint version.Design Decision
Keep the existing implementation and contracts as the baseline
Production code, public APIs, dependencies, lint settings, snapshots, and generated documentation remain unchanged. New regression tests associated with the deferred behavior/API changes are not included. Existing test cases are retained.
Preserve integration boundaries
Use
renderHookfor hook-only assertions instead of render-time/global result capture. Keep the routed layout around scroll-container tests, and retain integrated harnesses for DataTable DOM tests and React Hook Form so hook/UI lifecycle behavior is not changed by the cleanup. Navigation setup stays outside React render.The changes are organized into two commits: fixture/Suspense cleanup, followed by hook-result cleanup.
Summary
renderHook, without detached DOM harnesses or manual UI synchronization.