Repository navigation
Conversation
Opening adds a small upward slide (eased out) to the fade and zoom; closing is quicker (150ms, eased in) with a matching slide down. Skipped under prefers-reduced-motion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
Contributor
Code Metrics Report
Details | | main (403eebe) | #598 (3d0d032) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 88.1% | 88.1% | 0.0% |
| Files | 207 | 207 | 0 |
| Lines | 6178 | 6178 | 0 |
| Covered | 5448 | 5448 | 0 |
- | Test Execution Time | 2m18s | 2m19s | +1s |Code coverage of files in pull request scope (95.2% → 95.2%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft for discussion: makes
Dialogopen and close read more clearly. The change touches only the shared dialog, so every modal moves the same way.prefers-reduced-motion.CSS only, with existing
tw-animate-cssutilities and no new dependency. This is in line with the CSS-first animation direction (platform-planning#1510).Split out of the TreePicker / LineItems work (#597, #595). Component-specific motion, like the TreePicker's accordion, stays in those PRs; the shared dialog-level change lives here.
Open questions
--duration-*,--ease-*) planned in #1510?SheetandPopoverget matching treatment in the same pass?Test plan
/showcase/primitives: open is 200ms ease-out with the slide, close is 150ms ease-in🤖 Generated with Claude Code