Repository navigation
Conversation
Contributor
Code Metrics Report
Details | | main (403eebe) | #593 (33cf627) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 88.1% | 88.1% | 0.0% |
| Files | 207 | 207 | 0 |
| Lines | 6178 | 6178 | 0 |
| Covered | 5448 | 5448 | 0 |
+ | Test Execution Time | 2m18s | 2m16s | -2s |Code coverage of files in pull request scope (21.8% → 21.8%)
Reported by octocov |
added 4 commits
October 12, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #569. In the review, @interacsean asked whether the other rgba values in
default.cssshould reference colour tokens. This PR does that for the neutral colours. Nothing changes on screen.What this PR does
New primitives (internal, not bridged)
--primitive-white--primitive-white-a1to-a12and--primitive-black-a1to-a12. The values are RadixwhiteA/blackA(0.05, 0.1, 0.15, 0.2, 0.3, then 0.1 steps to 0.9, and 0.95).They are declared once next to the gray scale, because they are the same in both modes.
30 tokens in
default.cssnow read a step--background,--sidebar--card--popover--muted,--secondary--primary--primary-foreground--secondary-foreground-foregroundtokens--border--input--sidebar-borderWhite is its own step. The light page is gray-50 and cards are white, so putting cards on gray-50 would remove the difference.
New token
--backdrop--backdropisvar(--primitive-black-a7)(black at 50%) in both modes, bridged asbg-backdrop.Dialog,Sheetand the CsvImporter drawer use it instead ofbg-black/50.The name follows the CSS
::backdroppseudo-element, the Base UIBackdroppart and theshowBackdropoption ofSheet. I did not useoverlay, because--z-overlayalready names the modal layer, which holds both the backdrop and the popup.What changes for consumers
getComputedStyle(...).getPropertyValue()now gets the step's notation, for example#171717instead ofrgba(23, 23, 23, 1)for--cardin dark mode. The colour is the same. The "Verifying" note in the 1.x migration guide is updated to match.--backdropandbg-backdrop. Override--backdropon:rootto change every backdrop at once. Palettes inherit it.creamandbloomare not changed. They set their own values.Not in this PR
--accent, the shadows, the chart colours and--destructivestay literal. They have no matching step. (--destructiveis feat(core): alias --destructive to the danger roles and move components off destructive utilities #583.)creamandbloomkeep their own values. Their surfaces are tinted, so they do not map onto the neutral scale.z-50instead ofz-(--z-overlay). The value is the same. This is a separate small fix.docs-manifest.json, and the inherited-token comments intheme.cssand_template.css. The conflicts are small: keep both sides and runpnpm docs:sync. The PR that merges second will resolve them.Checks
fmt:check,lint,type-check,test(core: 2159 tests),docs:checkandbuildpass.semantic-contrast.test.tspins the resolved value of 19 neutral tokens in light and dark mode, so a step change that alters a colour fails.theme-bridge.test.tschecks that--backdropis defined and bridged. I changed one value and removed the bridge line on purpose to confirm both tests fail.bg-black/50tobg-backdroponly..astw\:bg-backdrop{background-color:var(--backdrop)}, anddist/themes/default.cssdefines--backdrop.decisions/semantic-color-roles.md, section "Update 2026-10-12". Docs: the Surface & chrome table in the styling guide. Changeset: minor.🤖 Generated with Claude Code