Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Fixes #8457
Brief Summary
Inline
ti.funcandti.pyfunccalls with an annotated tuple return raiseTypeError: 'tuple' object does not support item assignmentwhen the existing return conversion casts a scalar element. For example, an annotated scalar/Vector pair fails during compilation.Temporarily make tuple return data mutable while applying the existing casts, then restore the tuple. The regression coverage checks both decorators, the supported tuple annotation spellings, scalar positions, mixed Vector/Matrix/Struct results, forwarded returns, and existing container/single-return/Python-scope behavior.
Walkthrough
build_Return.Validation
3b1c3279dd781ba923f9f76d7defe973fe5d2583, Ubuntu 22.04, Python 3.11.16, LLVM 15.0.4: 25 regressions, 79 frontend cases, and 239 C++ cases pass; the full regular CPU selection has 2,412 passed / 258 skipped, and the serial selection has 7 passed / 1 skipped. Black, Pylint, whitespace, and end-of-file hooks pass. Imported native core reports the full final SHA, and pre/post-hook source blobs match that commit.test_inner_loops_local_variable_fixed_stack_size_kernel_grad[arch=x64],RuntimeError: argument not foundatkernel_impl.py:702, plus a duplicate worker-exit report. This later run is not an overall GREEN result; its cause is not established. The earlier successful run did not contain these full raw manifests, and the supplement is not presented as a historical receipt for it.ba0e81dce559fb63a5958bf82feb1d00c55c02fe. Its regular CPU result is 2,386 passed / 258 skipped / 1 failed, exit 1: a worker terminates while runningtest_sparse_matrix_nonsymmetric_multiplication[arch=x64-dtype3-row_major]. This baseline failure is retained; no causal claim is made about it.pip checkpassing. Full CPU selections exclude optional Torch/Paddle integrations and separate serial-marked cases; no failure-specific exclusion or-rretry is added. Earlier Python 3.12 exploratory runs failed and are retained separately: first, second, third. The third run's formal core had a stale baseline stamp and is not accepted as final-source proof.The validation helper and dependency constraints are confined to the public fork and are outside this two-file patch. GPU behavior was not validated.
AI assistance was used for investigation, implementation, and test authoring. The reported tests use Taichi's native source builds and existing runners.