Repository navigation
feat: add claim catalogs and enforce module boundaries - #70
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2debb8a22b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public sealed class GetPermissionsQueryValidator | ||
| : AbstractValidator<GetPermissionsQuery>; |
There was a problem hiding this comment.
Add a unit test for the query validator
When the architecture suite runs, ApplicationValidators_Should_HaveMatchingUnitTestFiles_When_ValidatorsAreDeclared discovers this AbstractValidator and requires a corresponding test file containing a Fact or Theory; this commit adds only GetPermissionsHandlerTests, so the suite fails until GetPermissionsQueryValidatorTests is added to the Identity unit-test project.
AGENTS.md reference: src/AGENTS.md:L1-L1
Useful? React with 👍 / 👎.
|
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |

0 New Issues
0 Fixed Issues
0 Accepted Issues
Changes
/api/v1/claims/permissionsand/api/v1/claims/sectionswith{ type, items }responses and validate user/role assignments against these catalogs.Validation
e9daa57: all test projects, architecture checks, formatting, Helm, and Sonar Quality Gate. New-code coverage: 100%; duplicated code: 0%; new issues: 0.dotnet test --project tests/PANiXiDA.TacticalHeroes.ArchitectureTests/PANiXiDA.TacticalHeroes.ArchitectureTests.csproj.dotnet test --project tests/PANiXiDA.TacticalHeroes.Common.UnitTests/PANiXiDA.TacticalHeroes.Common.UnitTests.csprojanddotnet test --project tests/Identity/PANiXiDA.TacticalHeroes.Identity.UnitTests/PANiXiDA.TacticalHeroes.Identity.UnitTests.csproj.dotnet test --project tests/Identity/PANiXiDA.TacticalHeroes.Identity.FunctionalTests/PANiXiDA.TacticalHeroes.Identity.FunctionalTests.csproj.Compatibility
/api/v1/permissionsis replaced by/api/v1/claims/permissions; its flat array becomes a type/items envelope. Permission items use section/resource metadata instead of group; section labels come from/api/v1/claims/sections.