Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Host initialized OpenTelemetry during functional tests and Wolverine code generation, while tests could silently compile handlers dynamically instead of checking the generated code used by deployment. Skip observability in the Test environment and for the codegen command, and add a strict pregenerated-handler test path.
Identity and Compendium web factories explicitly select the Host assembly. WOLVERINE_PREGENERATED=1 selects Static loading; ordinary tests retain Auto. A dedicated CI workflow generates handlers, recompiles them and runs the complete solution with Static. Production loading settings are unchanged.
The manually dispatched benchmark workflow compares clean-output build/test cycles on 20 separate GitHub runners. Each runner warms both variants and measures one pair; order is balanced 10/10. Total time includes the bootstrap Host build, codegen write, recompilation and all test projects with their containers. Restore, image downloads and warmups are excluded equally.
Test execution saved 10.914 seconds, while additional preparation cost 12.832 seconds. The complete cycle shows no statistically significant improvement. Retain the static path to validate pregenerated handlers, rather than claiming an end-to-end speed optimization.
Validation:
Method, full results and raw measurements are committed with the benchmark scripts. This experiment holds the observability flag constant; it measures pregeneration plus Static, including its generated handler registry. It does not measure deployed containers or the latency of the existing parallel CI matrix.