Version 2 (typescript, hooks, functional components) input wanted

[jonthomp]

Update: Work in progress on the version-2 branch, alpha is available on NPM.

npm install tabler-react@alpha
yarn add tabler-react@alpha

---

I've been thinking about a journey towards version 2 and some big internal changes that I think should happen along the way....

Given that Typescript is fast becoming, if it isn't already, the most widely used type system in React open source projects it may be a good time to also make the switch.

Features

• Typescript
• Components should will become React Hooks powered function components where possible.
• Everything should will work in React Strict Mode.
• Use Storybook and add visual tests using Chromatic.
• All packages/libs to be updated
• Fix outstanding issues
• Introduce missing features from the core repo
• Improve how CSS is imported and built from the main repo (and update to latest version)
• Make sure className and style props are available everywhere
• Always spread remaining props to underlying components and make sure any internal components can have their props set
• Base components providing style utility props
• Refs forwarded to the underlying HTML elements

Keen to hear any thoughts or additions?

cc @AaronCoplan @Greg-Hamel

[elucidsoft]

I have to be honest here, using Typescript would improve this framework by a significant amount. I just spent 2 hours on a really dumb bug where I had Router instead of Route and I sware I looked at it like 500 times and still didn't notice my stupidity. But even beyond that, I have to keep the documentation up constantly, where as if I had strong typing I would be able to utilize the intellisense. Just my 2 cents, I'm all for Typescript!

[jonthomp]

@elucidsoft there is now a fully converted to typescript branch here https://github.com/tabler/tabler-react/tree/typescript if you want to check it out

[rollymaduk]

@jonthomp thanks and nice work, please how should it be used in a create-react-app typescript project

[rollymaduk]

I cannot seem to find the module after installing the branch

[elucidsoft]

This doesn't appear to run when I use yarn start it gives a ton of warnings about circular dependencies and then just sits there...Not sure what it's doing tbh...

[jonthomp]

@elucidsoft @rollymaduk the typescript branch has been updated to fix some things, including the circular dependencies, however, you might be more interested in the version-2 branch as that includes further fixes and will be where work continues

[elucidsoft]

Alright, will take a look.

[jonthomp]

A quick note to say that the version 2 branch CSS is now up-to-date with the latest version of tabler

[jonthomp]

I've just published the first alpha 🎉

npm install tabler-react@alpha
yarn add tabler-react@alpha

Would love for people to give it a go on any existing tabler-react code basis and get some bug reports in!