Repository navigation
chore(ship): S28 retro: OS-handler URLs banned, eval before merge for verdict changes, run-wait 90, Downloads check, eval exit 1 without runs - #908
Merged
Conversation
…, eval before merge for verdict changes, run-wait 90 min, Downloads check in every brief, eval exits 1 when no run started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S28 retro for the ship skill, plus a fix to the eval harness script. No product code.
Tool bugs
mailto:,tel:,sms:,facetime:and others). In S28 amailto:redirect cell made macOS Chrome, even headless, open the owner's mail app again and again.ship brief --checknow refuses a brief that contains such a URL. A scheme named as a word, like the ban itself, doesn't count. Checked against every S28 brief and every open issue's text (those briefs quote the issue): no false refusal.<worktree>open as a placeholder in the design and verifier briefs. I added that line in chore(ship): S27 retro: cloud red-team kit in the skill, verifier foreign in gate 8, snapshot in ~/.cache/ship, FINDINGS, load warning #898.ls -A ~/Downloadsbefore the first and after the last test or bdg run, not only the tester. In S28 a reviewer's red-commit smoke run left files there.run-waitnow defaults to 90 minutes instead of 60. A ×10 repeat of fix: dom fill reads the value again 2 s after filling; a late revert exits 90 (#892) #900 (2 s perdom fill) took longer than 60.ci-wait: a PR waiter that has seen a CI run no longer gives up when one gh poll comes back empty. On this PR it saw "CI queued 4 min", then advised closing and reopening the PR (exit 4).scripts/agent-eval.mjsexits 1 and says why when the budget let no run start. It used to exit 0 with an empty summary.Red commit. None: tier 1…line.Process
main(about $0.10 a task)./simplifyremoval: back to 0, since S28's /simplify found real issues;log.md: the S28 rows.Verified
node --test .claude/skills/ship/scripts/ship.test.mjs: 120 pass, with a new test forosHandlerUrls;node --test scripts/agent-eval.test.mjs: 78 pass;--budget=0.1 --run-budget=0.5exited 1 with "no run started (budget: …)". It spent nothing.<worktree>left, and the ban text passes--check.