Consolidate user lifecycle mutations behind UserLifecycleService#1288
Draft
0x46616c6b wants to merge 1 commit into
Draft
Consolidate user lifecycle mutations behind UserLifecycleService#12880x46616c6b wants to merge 1 commit into
0x46616c6b wants to merge 1 commit into
Conversation
0x46616c6b
force-pushed
the
refactor/user-lifecycle-service
branch
from
a849b1f to
e4ad324
Compare
Replaced UserResetService, UserRestoreService, and DeleteHandler with a single UserLifecycleService seam (reset / delete / restore) and a MailCryptCredentialRotation collaborator that owns the ordering invariant: MailCryptKeyHandler must run before RecoveryTokenHandler because the recovery token encrypts the private key just set. The alias lifecycle concern is separated: deleteAlias is now inlined in AliasManager.delete() where it belongs; DeleteHandler becomes empty and is removed entirely. Co-Authored-By: Claude <claude@anthropic.com>
0x46616c6b
force-pushed
the
refactor/user-lifecycle-service
branch
from
e4ad324 to
f35dd45
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserResetService,UserRestoreService, andDeleteHandlerwith a singleUserLifecycleServiceseam exposing three methods:reset(),delete(),restore().MailCryptCredentialRotationto own the ordering invariant:MailCryptKeyHandler.create()must run beforeRecoveryTokenHandler.create()because the recovery token encrypts the private key just set on the user. This invariant previously lived in a comment; it now has a named home.deleteAliasis now inlined inAliasManager.delete()where it belongs.DeleteHandlerbecomes empty and is removed.CONTEXT.mddocumenting the new domain terms (User Lifecycle, MailCrypt Credential Rotation) for future AI and human navigators.The changes and the PR were generated by Claude.