Skip to content

Sevro readback shouldn't use ADC registers - #69

Merged
OldUser101 merged 2 commits into
masterfrom
fix/hardware-readback
Nov 2, 2026
Merged

OldUser101 merged 2 commits into
masterfrom
fix/hardware-readback

Conversation

@shardros

Copy link
Copy Markdown
Member

Reading a servo position used the ADC registers. Reading a motor gave 12.5 after setting -50.

  • brain/greengiant: fix reading servo position
  • brain/greengiant: fix reading motor power

shardros and others added 2 commits October 31, 2026 17:54
The getter read the ADC registers rather than the PWM registers, and on PiLow
didn't invert the scaling used by the setter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scaling factor was multiplied rather than divided and the sign was dropped,
so `I.motors[0] = -50` read back as 12.5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@OldUser101
OldUser101 merged commit e613867 into master Nov 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants