Repository navigation
Sevro readback shouldn't use ADC registers - #69
Merged
Merged
Conversation
The getter read the ADC registers rather than the PWM registers, and on PiLow didn't invert the scaling used by the setter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scaling factor was multiplied rather than divided and the sign was dropped, so `I.motors[0] = -50` read back as 12.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OldUser101
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a servo position used the ADC registers. Reading a motor gave 12.5 after setting -50.