Repository navigation
fix: print repository error prefix once; reject blank hsearch queries - #81
Merged
Merged
Conversation
DomainError::RepositoryError already prefixes its message with "Repository error:". RepositoryError::Other added the same prefix, and every context() call and OperationFailed conversion ends up in Other, so users saw "Repository error: Repository error: ...". Display Other as the bare message, like the Other variants of all the other error enums.
An empty or whitespace-only query reached FTS5 and failed with "fts5: syntax error near """. Reject it before any search runs, and point to search for tag-only browsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #80, which was merged before these two commits were pushed.
fix(errors): print the repository error prefix onceRepository error: Repository error: …—RepositoryError::Otherrepeated the prefix itsDomainErrorwrapper already addsOtherdisplays the bare message, like all otherOthervariantsfix(hsearch): reject blank queries with a validation errorfts5: syntax error near ""searchfor tag-only browsingBefore / after:
Testing
Tests written first and verified failing on
main:Repository error:exactly once (context-wrappedQueryand plainOther)hsearchqueries returnApplicationError::Validationmake testgreen.