Skip to content

chore: clean up generated mobile artifacts - #11

Merged
ovitrif merged 6 commits into
masterfrom
chore/cleanup
Aug 18, 2026
Merged

chore: clean up generated mobile artifacts#11
ovitrif merged 6 commits into
masterfrom
chore/cleanup

Conversation

@pwltr

@pwltr pwltr commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Stop tracking generated iOS XCFramework artifacts in git
  • Stop tracking generated Android Kotlin bindings, native libraries, and debug symbols in git
  • Move generated iOS release artifacts to dist/ios
  • Keep bindings/ios focused on SwiftPM source/interface files
  • Update Swift package support to iOS 17 only
  • Remove Python bindings and Python build entrypoints
  • Update README, agent docs, ignore rules, and CI paths for the iOS/Android-only build flow

Details

This cleans up the package layout so generated binary artifacts are no longer committed to the repository.

The iOS build now writes generated release artifacts to:

  • dist/ios/VssRustClientFfi.xcframework
  • dist/ios/VssRustClientFfi.xcframework.zip

bindings/ios now only contains the Swift wrapper source and C interface files consumed by Package.swift.

The Android build continues to generate its Kotlin binding, JNI libraries, and debug symbols under bindings/android, but those generated outputs are ignored by git and produced by ./build_android.sh or CI.

The Swift package now requires iOS 17+, matching Bitkit iOS’s minimum deployment target and the iOS artifact build configuration.

Python binding support has been removed from the build surface, including build_python.sh, bindings/python, and related README/agent instructions. ./build.sh all now builds iOS and Android only.

Testing

  • Ran ./build_ios.sh successfully and verified the XCFramework is generated under dist/ios
  • Ran shell syntax checks:
    • bash -n build.sh
    • bash -n build_ios.sh
    • bash -n build_android.sh
  • Validated SwiftPM manifest after the iOS 17/tools-version update
  • Updated CI validation paths so iOS bindgen checks dist/ios and validation no longer references removed Python scripts

@ovitrif ovitrif closed this Jun 15, 2026
@ovitrif
ovitrif deleted the chore/cleanup branch June 15, 2026 09:13
@pwltr

pwltr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@ovitrif Any reason you closed these PRs?

@ovitrif
ovitrif restored the chore/cleanup branch June 16, 2026 10:48
@ovitrif ovitrif reopened this Jun 16, 2026
@ovitrif

ovitrif commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@ovitrif Any reason you closed these PRs?

By mistake I reckon, sorry for that.

@pwltr
pwltr marked this pull request as draft August 14, 2026 14:16
@pwltr pwltr changed the title chore: cleanup chore: clean up generated mobile artifacts Aug 18, 2026
@pwltr
pwltr marked this pull request as ready for review August 18, 2026 16:12
@pwltr

pwltr commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Note: release automation for iOS artifacts is intentionally deferred. See the Phase 2 decision here: #22 (comment)

@pwltr
pwltr requested a review from ovitrif August 18, 2026 16:12

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because generated mobile artifacts are no longer tracked, iOS release outputs go to dist/ios, and Python binding entrypoints are removed.

@ovitrif
ovitrif merged commit d0e3fd6 into master Aug 18, 2026
3 checks passed
@ovitrif
ovitrif deleted the chore/cleanup branch August 18, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants