chore: clean up generated mobile artifacts - #11
Merged
Merged
Conversation
Contributor
Author
|
@ovitrif Any reason you closed these PRs? |
Collaborator
By mistake I reckon, sorry for that. |
pwltr
marked this pull request as draft
August 14, 2026 14:16
pwltr
marked this pull request as ready for review
August 18, 2026 16:12
Contributor
Author
|
Note: release automation for iOS artifacts is intentionally deferred. See the Phase 2 decision here: #22 (comment) |
ovitrif
approved these changes
Aug 18, 2026
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
Approved because generated mobile artifacts are no longer tracked, iOS release outputs go to dist/ios, and Python binding entrypoints are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/iosbindings/iosfocused on SwiftPM source/interface filesDetails
This cleans up the package layout so generated binary artifacts are no longer committed to the repository.
The iOS build now writes generated release artifacts to:
dist/ios/VssRustClientFfi.xcframeworkdist/ios/VssRustClientFfi.xcframework.zipbindings/iosnow only contains the Swift wrapper source and C interface files consumed byPackage.swift.The Android build continues to generate its Kotlin binding, JNI libraries, and debug symbols under
bindings/android, but those generated outputs are ignored by git and produced by./build_android.shor CI.The Swift package now requires iOS 17+, matching Bitkit iOS’s minimum deployment target and the iOS artifact build configuration.
Python binding support has been removed from the build surface, including
build_python.sh,bindings/python, and related README/agent instructions../build.sh allnow builds iOS and Android only.Testing
./build_ios.shsuccessfully and verified the XCFramework is generated underdist/iosbash -n build.shbash -n build_ios.shbash -n build_android.shdist/iosand validation no longer references removed Python scripts