Skip to content

fix: prevent false on-chain send success - #727

Draft
ovitrif wants to merge 4 commits into
masterfrom
codex/717-onchain-send-result
Draft

fix: prevent false on-chain send success#727
ovitrif wants to merge 4 commits into
masterfrom
codex/717-onchain-send-result

Conversation

@ovitrif

@ovitrif ovitrif commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Refs #717

Description

  • Propagate accepted-only on-chain send results from LDK Node to the existing success flow.
  • Preserve rejected, failed, timed-out, and not-dispatched outcomes as errors so they cannot reach Bitcoin Sent.
  • Adapt the app's NodeError mapping to rc.67's typed error contract and retain the transaction id in safe diagnostics.
  • Cover amount and maximum sends, accepted results, all four broadcast outcomes, and wrapped error classification.

Dependency

Preview

717-current-artifact-accepted.mp4
717-current-artifact-rejected.mp4

QA Notes

  • Current head 1ddd21e rebased on 215a9f10.
  • git diff --check passes.
  • Focused OnchainSendResultTests passed 7/7 against the verified unpublished 0.7.0-rc.67 artifact.
  • Current-artifact consumer build and isolated simulator flow passed with the local-only E2E_ELECTRUM_URL=tcp://127.0.0.1:62001 fixture override; no source override was committed.
  • Marketplace regtest corroborated the 1,000 sat send as transaction 158bdd1c2b81413b451f16b3331d261086daa73d03869e7a72099e5e83c6b04c, confirmed in block 00941d326f26ccedfec7305849c0c176442a9e3c1509dc2c0b9a934768d5fc5b.
  • Rejected current-artifact path remains user-visible as Transaction Failed for the recorded non-final backend rejection.

Validated against the exact local LDK Node 0.7.0-rc.67 artifact from ldk-node#113. Publication requires non-author approval of ldk-node#113 and an authorized rc.67 release.
@ovitrif ovitrif self-assigned this Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant