fix: prevent false on-chain send success - #727
Draft
ovitrif wants to merge 4 commits into
Draft
Conversation
Validated against the exact local LDK Node 0.7.0-rc.67 artifact from ldk-node#113. Publication requires non-author approval of ldk-node#113 and an authorized rc.67 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #717
Description
Bitcoin Sent.NodeErrormapping to rc.67's typed error contract and retain the transaction id in safe diagnostics.Dependency
synonymdev/ldk-node#113, head505b1a6, stacked on feat: LNURL withdraw #115.0.7.0-rc.67Swift artifact. Local validation used its verified artifact; no release has been created.Preview
717-current-artifact-accepted.mp4
717-current-artifact-rejected.mp4
QA Notes
1ddd21erebased on215a9f10.git diff --checkpasses.OnchainSendResultTestspassed 7/7 against the verified unpublished0.7.0-rc.67artifact.E2E_ELECTRUM_URL=tcp://127.0.0.1:62001fixture override; no source override was committed.158bdd1c2b81413b451f16b3331d261086daa73d03869e7a72099e5e83c6b04c, confirmed in block00941d326f26ccedfec7305849c0c176442a9e3c1509dc2c0b9a934768d5fc5b.Transaction Failedfor the recordednon-finalbackend rejection.