feat: add Paykit subscriptions - #685
Conversation
This comment has been minimized.
This comment has been minimized.
fee8601 to
01c4164
Compare
a8d71d0 to
059eb83
Compare
01c4164 to
bcf1d8a
Compare
059eb83 to
69a0746
Compare
69a0746 to
3a1bcd2
Compare
|
Restacked on the updated payment-proof branch at c3f2d8c. The subscription layer is unchanged; all commits remain signed, and the complete payment-proof suite (including recurring periods and uncertain on-chain recovery) passes 22/22. |
c3f2d8c to
281b865
Compare
3a1bcd2 to
cf4cea2
Compare
|
Restacked again on the final signed payment-proof hardening head |
281b865 to
e66771b
Compare
d68a602 to
c274b0a
Compare
|
The subscriptions branch is now correctly restacked on the current signed #683 head ( |
c274b0a to
e641682
Compare
|
Restacked onto #683 signed head Post-restack simulator verification passes 134/134 across |
|
Follow-up pushed in |
93871a4 to
6f66b33
Compare
|
Updated per the Figma clarification: the overview now shows a normalized Monthly Cost across all active subscriptions, independent of whether their current periods are paid. Daily, weekly, monthly, and yearly recurrences are annualized to a monthly value; each subscription is rounded to the nearest satoshi before safe aggregation. The obsolete calendar-month refresh was removed, and regression coverage includes recurrence normalization, paid active subscriptions, inactive exclusions, and low-value rounding. |
ovitrif
left a comment
There was a problem hiding this comment.
PaykitPaymentRequestManager.acceptedAt(for:) is unused after Monthly Cost stopped reading calendar-month due counts.
The hardware before-broadcast path now marks the on-chain proof started.
Description
Adds the payer side of Paykit subscriptions, stacked on #683.
This PR intentionally covers payer-side receipt only. Subscription creation, Discover, automatic payment without confirmation, and renewal are not included because they are outside this MVP or are not currently exposed by Paykit.
Dependencies:
0.1.0-rc46Linked Issues/Tasks
Screenshot / Video
Final iOS and cross-platform proof recordings were completed locally; they are not attached to the PR.
QA Notes
Manual Tests
Automated Checks
PaykitPaymentRequestServiceTestsandPaykitPaymentProofServiceTestsgit diff --check