[ovitrif]

Twin: synonymdev/bitkit-android#1699
Companion: synonymdev/bitkit-e2e-tests#285
Refs: synonymdev/blocktank-lsp-http#168

Description

• Skips the four integration tests that create Blocktank orders or CJIT entries, because Blocktank staging now serves the read-only API: POST /channels and POST /cjit return 404.
  • BlocktankTests.testCreateCjitOrder
  • BlocktankTests.testOrders
  • PaymentFlowTests.testchannelPurchaseFlow
  • BlocktankRefundAddressLiveIntegrationTests.testRefundAddressLifecycleAcrossOrdersRestartAndVssRestore
• Read-only cases such as BlocktankTests.testGetInfo keep running.

Out of Scope

• Blocktank sunset UI: handled in feat: blocktank sunset #1127.
• E2E specs that buy channels: handled in test: stop buying blocktank channels in e2e specs bitkit-e2e-tests#285.

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

• updated BlocktankTests.swift — order and CJIT creation cases skipped
• updated ChannelPurchaseFlow.swift — channel purchase flow skipped
• updated BlocktankRefundAddressLiveIntegrationTests.swift — refund address lifecycle skipped

Evidence

• Before: integration run https://github.com/synonymdev/bitkit-ios/actions/runs/40343422085 fails only these four tests, each on a Blocktank 404 (Failed to create order / Failed to create CJIT entry).

Gaps

None.

Models used

• Planning/scoping: Claude Opus 5.5 (reasoning: low)
• Implementation: Claude Opus 5.5 (reasoning: low)
• Review: Not performed

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T16:08:56.084144Z	e85ee82	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[talosmachina]

No findings. Adds XCTSkipIf(true, …) to the four integration tests that create a Blocktank order or a CJIT entry, now that staging refuses those writes. Reviewed e85ee82, light tier. Reasoned from the code and CI, not built here (no Xcode on Linux).

What I checked, and 3 candidates I ruled out

Read in full: BlocktankTests.swift, ChannelPurchaseFlow.swift, BlocktankRefundAddressLiveIntegrationTests.swift
Call sites traced: createOrder and createCjit across BitkitTests. Also the -only-testing list in integration-tests.yml and the matching -skip-testing list in unit-tests.yml.
CI: SwiftFormat, validate and e2e-status are green. Run Tests and Run Integration Tests were still pending.

Ruled out

• The skip list misses a test: the linked run 40343422085 fails exactly these four (testRefundAddressLifecycleAcrossOrdersRestartAndVssRestore, testCreateCjitOrder, testOrders, testchannelPurchaseFlow). Each one fails twice under the retry (8 failures in 38), every time on Failed to create order / Failed to create CJIT entry … Not found. The other integration classes in that run passed.
• Other createOrder callers reach staging: the hits in BlocktankRefundAddressProviderTests.swift and TransferViewModelTests.swift run against stubs and are on the unit side of the split. ReceiveLiquidityDecisionTests only compares a .createCjit enum value.
• Read-only cases also break: against the regtest staging base just now, GET /info and POST /channels/estimate-fee-full returned 200 and POST /channels returned 404, so testGetInfo stays valid.

Merge confidence: 4/5, no findings, but Run Integration Tests on this head had not finished when I reviewed it.

Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed (the review runner does not report a reasoning setting)