Repository navigation
Conversation
iroh reads network interfaces through Network.framework, so apps that link BitkitCore without it fail with undefined nw_* symbols.
# Conflicts: # AGENTS.md # Cargo.lock # Cargo.toml # Package.swift # bindings/android/gradle.properties # src/lib.rs
Collaborator
Author
|
Closing this PR: after a full mainnet QA run on Android and iOS, Bitkit goes with Spark for Lightning. Arkade worked end to end with real funds (LN send and receive, Lightning address, transfers to and from Savings), but it needs too much built and run on our side: chain access through block explorers, our own LN swap client and the activity history. The branch stays for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency:
On hold: Bitkit goes with Spark for Lightning for now, so this stays parked as it is.
This PR lets an Arkade offboard pay a Paykit contact who only accepts on-chain bitcoin, as a service leg in the Paykit router.
Description
arkade_paykit_route_leg(endpoint, amount_sat): a leg that offboards exactlyamount_satto the contact's on-chain address, with the operator's exit fee on top, orNonewhile the available Arkade balance cannot cover both. The fee comes from the operator's own fee programs, evaluated the wayarkade_offboardevaluates them. The app passes the leg topubky_swaps_route_paykit_paymentinservice_legs.arkade_offboard_exact(address, amount_sat), which runs the leg: the contact receives exactlyamount_satin the next batch, and the exit fee comes on top.arkade_offboardkeeps its behaviour, where the fee comes out of the amount.operatoratomicity: the operator co-signs the batch that pays the contact.0.8.0-routes.1, which the Arkade app branches use.Cross-platform impact
arkade_paykit_route_legandarkade_offboard_exact. No existing export changes beyond feat: pay contacts via spark #184's.What it needs to ship
Preview
N/A — library change; no recording yet.
QA Notes
Setup
N/A — no device testing required: the change is covered by unit tests, and no app journey exists yet.
Automated Checks
cargo fmt --check,cargo clippy --lib --tests(no findings inarkadeorpubky_swaps),cargo test --lib pubky_swapsandcargo test --lib modules::arkade: passarkade_paykit_route_legitself: it needs a running wallet and operatorModels used
claude-opus-5-5(reasoning:medium)claude-opus-5-5(reasoning:medium)