Skip to content

bug: older auto-paid totals and tags disappear after 200 allowance payments #1584

Closed

Description

@ovitrif

Refs:

What happened?

The allowance journal keeps only the last 200 attempts (takeLast(MAX_JOURNAL_ENTRIES) in PaykitAllowanceExecutor), yet the "Paid automatically" totals and the "Auto-paid" tag are rebuilt only from that journal. Manual payments of incoming requests are journaled too and count toward the same limit.

After 200 newer attempts, an older automatic payment drops out of its allowance's paid total and loses its Auto-paid tag; an ended allowance's displayed total can shrink the same way.

Expected behavior

Lasting totals and the ids of automatically paid requests are kept apart from the trimmed recovery journal, so trimming old recovery records never changes what the user sees.

Steps to Reproduce

  1. Have one allowance pay a request automatically.
  2. Make 200 more allowance or manual request payments.
  3. The first payment no longer counts in the allowance total and shows no Auto-paid tag.

Bitkit Version

Unreleased: allowances branch of #1340.

Reproducibility

Always, from the code path; not yet run on a device.

Activity

  1. added this to the 3.2.0 milestone on Oct 19, 2026
  2. self-assigned this
    on Oct 19, 2026
  3. added theissue type on Oct 19, 2026
  4. removed their assignment
    on Oct 19, 2026
  5. self-assigned this
    on Oct 26, 2026
  6. modified the milestones: 3.2.0, 3.1.0 on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions