Update Artifact Lambda Unit Tests & Refactor for ruff#6
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s developer tooling and CI workflows to use Ruff, refreshes unit test mocking to align with newer Moto patterns, and migrates repository documentation from README.md to README.rst.
Changes:
- Update dev dependencies (pytest/moto) and replace Black/Flake8 with Ruff.
- Refactor unit tests to use Moto’s unified AWS mocking and introduce a pytest fixture.
- Modernize GitHub Actions workflows for testing, coverage upload, and Ruff-based lint/format.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.dev.txt | Updates test/dev dependencies and switches linting/formatting tooling to Ruff. |
| README.rst | Adds a new reStructuredText README with updated test/run instructions and badges. |
| README.md | Removes the previous Markdown README in favor of README.rst. |
| lambda_function/tests/test_process_artifacts.py | Updates Moto usage and refactors test setup to use a pytest fixture. |
| lambda_function/src/process_artifacts/process_artifacts.py | Ruff-oriented refactor: import ordering, typing, and updated docstrings. |
| lambda_function/src/lambda.py | Adds typing and refreshes handler documentation. |
| lambda_function/src/config.yaml | Removes the previously committed config file. |
| .github/workflows/testing.yml | Updates CI environment/actions and adds Codecov upload step. |
| .github/workflows/codestyle.yml | Replaces Black/Flake8 workflow with Ruff-based lint/format. |
| .github/workflows/build_and_push.yml | Removes the prior self-hosted Docker build/push workflow. |
Comments suppressed due to low confidence (1)
requirements.dev.txt:8
- All other dev tools here are version-pinned, but
ruffis left unpinned. This can make CI results non-reproducible when Ruff releases new rules/formatting. Consider pinning Ruff to a known-good version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.