Skip to content

Fix JavaScriptEventLoop for Embedded Swift in main toolchain snapshots #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxDesiatov merged 1 commit into from
Jul 1, 2026
Merged

Fix JavaScriptEventLoop for Embedded Swift in main toolchain snapshots #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions Sources/JavaScriptEventLoop/JavaScriptEventLoop+ExecutorFactory.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,13 @@ extension JavaScriptEventLoop: SchedulingExecutor {
tolerance: C.Duration?,
clock: C
) {
#if hasFeature(Embedded)
#if compiler(>=6.4)
// In Embedded Swift, ContinuousClock and SuspendingClock are unavailable.
// Hand-off the scheduling work to the Clock implementation for custom clocks.
clock.enqueue(
job,
on: self,
at: clock.now.advanced(by: delay),
tolerance: tolerance
)
#if $Embedded
// ContinuousClock and SuspendingClock are unavailable in Embedded Swift,
// but Swift.Duration is, and every standard clock uses it.
guard let duration = delay as? Duration else {
fatalError("Unsupported clock type; only Duration-based clocks are supported in Embedded Swift")
}
#else
fatalError(
"Delayed enqueue requires Swift 6.4+ in Embedded mode"
)
#endif // #if compiler(>=6.4) (Embedded)
#else // #if hasFeature(Embedded)
let duration: Duration
if let _ = clock as? ContinuousClock {
duration = delay as! ContinuousClock.Duration
Expand All @@ -64,12 +55,12 @@ extension JavaScriptEventLoop: SchedulingExecutor {
} else {
fatalError("Unsupported clock type; only ContinuousClock and SuspendingClock are supported")
}
#endif
let milliseconds = Self.delayInMilliseconds(from: duration)
self.enqueue(
UnownedJob(job),
withDelay: milliseconds
)
#endif // #if hasFeature(Embedded)
}

private static func delayInMilliseconds(from swiftDuration: Duration) -> Double {
Expand Down
Loading