Repository navigation
Conversation
This PR adopts typed throws in `withKnownIssue()` and its support code. The adoption of typed throws is an ABI-breaking change and a visible change to our API surface, so we may need to go through Swift Evolution for this change.
grynspan
added
public-api
grynspan
added
the
typed-throws
grynspan
requested review from
briancroom,
harlanhaskins and
jerryjrchen
as code owners
October 30, 2026 20:18
Contributor
Author
|
Looks like we can't merge this because the type checker doesn't want to pick the non-throwing overload of |
grynspan
marked this pull request as draft
October 30, 2026 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adopts typed throws in
withKnownIssue()and its support code. The adoption of typed throws is an ABI-breaking change and a visible change to our API surface, so we may need to go through Swift Evolution for this change. Or, we can consider SE-0413 § Standard library operations thatrethrowas binding precedent.Checklist: