Repository navigation
Conversation
This PR adopts typed throws in `FileHandle`, which almost exclusively throws errors of type `CError` (representing the same error domain as Foundation's `POSIXError`) or errors provided by a callback. We must still use untyped throws in one spot, which I've noted as audited by changing the signature to explicitly `throws(any Error)`. Sum types would help us avoid situations like this one.
grynspan
added
performance
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
October 30, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adopts typed throws in
FileHandle, which almost exclusively throws errors of typeCError(representing the same error domain as Foundation'sPOSIXError) or errors provided by a callback.We must still use untyped throws in one spot, which I've noted as audited by changing the signature to explicitly
throws(any Error). Sum types would help us avoid situations like this one.Checklist: